Rename Scalar::halve() to Scalar::div_by_2()

Author: daxpedda

ed448-goldilocks/src/decaf/scalar.rs

@@ -153,9 +153,9 @@ mod test {
         let eight = DecafScalar::from(8u8);
         let four = DecafScalar::from(4u8);
         let two = DecafScalar::from(2u8);
-        assert_eq!(eight.halve(), four);
-        assert_eq!(four.halve(), two);
-        assert_eq!(two.halve(), DecafScalar::ONE);
+        assert_eq!(eight.div_by_2(), four);
+        assert_eq!(four.div_by_2(), two);
+        assert_eq!(two.div_by_2(), DecafScalar::ONE);
     }
 
     #[test]

ed448-goldilocks/src/edwards/extended.rs

@@ -334,7 +334,7 @@ impl EdwardsPoint {
     /// Generic scalar multiplication to compute s*P
     pub fn scalar_mul(&self, scalar: &EdwardsScalar) -> Self {
         // Compute floor(s/4)
-        let scalar_div_four = scalar.halve().halve();
+        let scalar_div_four = scalar.div_by_2().div_by_2();
 
         // Use isogeny and dual isogeny to compute phi^-1((s/4) * phi(P))
         variable_base(&self.to_twisted(), &scalar_div_four).to_untwisted()

ed448-goldilocks/src/edwards/scalar.rs

@@ -169,9 +169,9 @@ mod test {
         let eight = EdwardsScalar::from(8u8);
         let four = EdwardsScalar::from(4u8);
         let two = EdwardsScalar::from(2u8);
-        assert_eq!(eight.halve(), four);
-        assert_eq!(four.halve(), two);
-        assert_eq!(two.halve(), EdwardsScalar::ONE);
+        assert_eq!(eight.div_by_2(), four);
+        assert_eq!(four.div_by_2(), two);
+        assert_eq!(two.div_by_2(), EdwardsScalar::ONE);
     }
 
     #[test]

ed448-goldilocks/src/field/scalar.rs

@@ -771,7 +771,7 @@ impl<C: CurveWithScalar> Scalar<C> {
     }
 
     /// Halves a Scalar modulo the prime
-    pub fn halve(&self) -> Self {
+    pub fn div_by_2(&self) -> Self {
         let is_odd = self.scalar.is_odd();
         let if_odd = self.scalar + *ORDER;
         let scalar = U448::conditional_select(&self.scalar, &if_odd, is_odd);