CI: bump clippy to v1.89 (#1400)

Also includes some small fixes for redundant lints

Author: tarcieri

.github/workflows/workspace.yml

@@ -22,12 +22,12 @@ jobs:
   clippy:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v5
-    - uses: dtolnay/rust-toolchain@master
-      with:
-        toolchain: 1.88.0
-        components: clippy
-    - run: cargo clippy --all --all-features -- -D warnings
+      - uses: actions/checkout@v5
+      - uses: dtolnay/rust-toolchain@master
+        with:
+          toolchain: 1.89 # pinned to prevent breakages when new stable versions are released
+          components: clippy
+      - run: cargo clippy --all --all-features -- -D warnings
 
   rustfmt:
     runs-on: ubuntu-latest

p192/src/arithmetic/scalar.rs

@@ -10,15 +10,8 @@
 //! Apache License (Version 2.0), and the BSD 1-Clause License;
 //! users may pick which license to apply.
 
-#![allow(clippy::unusual_byte_groupings)]
-
 #[cfg_attr(target_pointer_width = "32", path = "scalar/p192_scalar_32.rs")]
 #[cfg_attr(target_pointer_width = "64", path = "scalar/p192_scalar_64.rs")]
-#[allow(
-    clippy::identity_op,
-    clippy::too_many_arguments,
-    clippy::unnecessary_cast
-)]
 mod scalar_impl;
 
 use self::scalar_impl::*;

p224/src/arithmetic/scalar.rs

@@ -10,15 +10,8 @@
 //! Apache License (Version 2.0), and the BSD 1-Clause License;
 //! users may pick which license to apply.
 
-#![allow(clippy::unusual_byte_groupings)]
-
 #[cfg_attr(target_pointer_width = "32", path = "scalar/p224_scalar_32.rs")]
 #[cfg_attr(target_pointer_width = "64", path = "scalar/p224_scalar_64.rs")]
-#[allow(
-    clippy::identity_op,
-    clippy::too_many_arguments,
-    clippy::unnecessary_cast
-)]
 mod scalar_impl;
 
 use self::scalar_impl::*;

p384/src/arithmetic/scalar.rs

@@ -10,15 +10,8 @@
 //! Apache License (Version 2.0), and the BSD 1-Clause License;
 //! users may pick which license to apply.
 
-#![allow(clippy::unusual_byte_groupings)]
-
 #[cfg_attr(target_pointer_width = "32", path = "scalar/p384_scalar_32.rs")]
 #[cfg_attr(target_pointer_width = "64", path = "scalar/p384_scalar_64.rs")]
-#[allow(
-    clippy::identity_op,
-    clippy::too_many_arguments,
-    clippy::unnecessary_cast
-)]
 mod scalar_impl;
 
 use self::scalar_impl::*;