Remove deprecated error descriptions

Error descriptions are soft-deprecated
since 1.27.0, and hard-deprecated since
1.42.0.

Our MSRV is 1.36.0 so well above the
1.27.0 bound.

See also rust-lang/rust#66919

Author: est31

src/audio.rs

@@ -51,20 +51,17 @@ impl From<()> for AudioReadError {
 	}
 }
 
-impl error::Error for AudioReadError {
-	fn description(&self) -> &str {
-		match self {
-			&AudioReadError::EndOfPacket => "End of packet reached.",
-			&AudioReadError::AudioBadFormat => "Invalid audio packet",
-			&AudioReadError::AudioIsHeader => "The vorbis version is not supported",
-			&AudioReadError::BufferNotAddressable => "Requested to create buffer of non-addressable size",
-		}
-	}
-}
+impl error::Error for AudioReadError {}
 
 impl fmt::Display for AudioReadError {
 	fn fmt(&self, fmt: &mut fmt::Formatter) -> Result<(), fmt::Error> {
-		write!(fmt, "{}", error::Error::description(self))
+		let description = match self {
+			AudioReadError::EndOfPacket => "End of packet reached.",
+			AudioReadError::AudioBadFormat => "Invalid audio packet",
+			AudioReadError::AudioIsHeader => "The vorbis version is not supported",
+			AudioReadError::BufferNotAddressable => "Requested to create buffer of non-addressable size",
+		};
+		write!(fmt, "{}", description)
 	}
 }
 
@@ -120,7 +117,7 @@ fn floor_zero_decode(rdr :&mut BitpackCursor, codebooks :&[Codebook],
 		// This channel is unused in this frame,
 		// its all zeros.
 		return Err(FloorSpecialCase::Unused);
-	} 
+	}
 
 	let booknumber = try!(rdr.read_dyn_u32(
 		::ilog(fl.floor0_number_of_books as u64)));
@@ -268,7 +265,7 @@ fn extr_neighbor<F>(v :&[u32], max_idx :usize,
 	// the criterion of being "smaller" than bound
 	let min_idx = prefix.iter()
 		.position(|&val| smaller(val, bound))
-		.unwrap_or_else(|| 
+		.unwrap_or_else(||
 			panic!("No index y < {0} found where v[y] is {1} than v[{0}] = 0x{2:08x}!",
 				max_idx, relation, bound));
 

src/header.rs

@@ -92,24 +92,21 @@ impl From<FromUtf8Error> for HeaderReadError {
 	}
 }
 
-impl error::Error for HeaderReadError {
-	fn description(&self) -> &str {
-		match self {
-			&HeaderReadError::EndOfPacket => "End of packet reached.",
-			&HeaderReadError::NotVorbisHeader => "The packet is not a vorbis header",
-			&HeaderReadError::UnsupportedVorbisVersion => "The vorbis version is not supported",
-			&HeaderReadError::HeaderBadFormat => "Invalid header",
-			&HeaderReadError::HeaderBadType(_) => "Invalid/unexpected header type",
-			&HeaderReadError::HeaderIsAudio => "Packet seems to be audio",
-			&HeaderReadError::Utf8DecodeError => "UTF-8 decoding error",
-			&HeaderReadError::BufferNotAddressable => "Requested to create buffer of non-addressable size",
-		}
-	}
-}
+impl error::Error for HeaderReadError {}
 
 impl fmt::Display for HeaderReadError {
 	fn fmt(&self, fmt: &mut fmt::Formatter) -> Result<(), fmt::Error> {
-		write!(fmt, "{}", error::Error::description(self))
+		let description = match self {
+			HeaderReadError::EndOfPacket => "End of packet reached.",
+			HeaderReadError::NotVorbisHeader => "The packet is not a vorbis header",
+			HeaderReadError::UnsupportedVorbisVersion => "The vorbis version is not supported",
+			HeaderReadError::HeaderBadFormat => "Invalid header",
+			HeaderReadError::HeaderBadType(_) => "Invalid/unexpected header type",
+			HeaderReadError::HeaderIsAudio => "Packet seems to be audio",
+			HeaderReadError::Utf8DecodeError => "UTF-8 decoding error",
+			HeaderReadError::BufferNotAddressable => "Requested to create buffer of non-addressable size",
+		};
+		write!(fmt, "{}", description)
 	}
 }
 

src/lib.rs

@@ -123,20 +123,16 @@ pub enum VorbisError {
 	OggError(OggReadError),
 }
 
-impl std::error::Error for VorbisError {
-	fn description(&self) -> &str {
-		match self {
-			&VorbisError::BadAudio(_) => "Vorbis bitstream audio decode problem",
-			&VorbisError::BadHeader(_) => "Vorbis bitstream header decode problem",
-			#[cfg(feature = "ogg")]
-			&VorbisError::OggError(ref e) => e.description(),
-		}
-	}
-}
+impl std::error::Error for VorbisError {}
 
 impl std::fmt::Display for VorbisError {
 	fn fmt(&self, fmt: &mut std::fmt::Formatter) -> Result<(), std::fmt::Error> {
-		write!(fmt, "{}", std::error::Error::description(self))
+		write!(fmt, "{}", match self {
+			VorbisError::BadAudio(_) => "Vorbis bitstream audio decode problem",
+			VorbisError::BadHeader(_) => "Vorbis bitstream header decode problem",
+			#[cfg(feature = "ogg")]
+			VorbisError::OggError(_) => "Ogg decode problem",
+		})
 	}
 }