Skip to content

Commit fea8cdf

Browse files
LorenzoBianconiPaolo Abeni
authored andcommitted
net: airoha: Fix loopback mode configuration for GDM2 port
Add missing configuration for loopback mode in airhoha_set_gdm2_loopback routine. Fixes: 9cd451d ("net: airoha: Add loopback support for GDM2") Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com> Link: https://patch.msgid.link/20251008-airoha-loopback-mode-fix-v2-1-045694fe7f60@kernel.org Signed-off-by: Paolo Abeni <pabeni@redhat.com>
1 parent e6cc7ac commit fea8cdf

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

drivers/net/ethernet/airoha/airoha_eth.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1710,7 +1710,9 @@ static void airhoha_set_gdm2_loopback(struct airoha_gdm_port *port)
17101710
airoha_fe_wr(eth, REG_GDM_RXCHN_EN(2), 0xffff);
17111711
airoha_fe_rmw(eth, REG_GDM_LPBK_CFG(2),
17121712
LPBK_CHAN_MASK | LPBK_MODE_MASK | LPBK_EN_MASK,
1713-
FIELD_PREP(LPBK_CHAN_MASK, chan) | LPBK_EN_MASK);
1713+
FIELD_PREP(LPBK_CHAN_MASK, chan) |
1714+
LBK_GAP_MODE_MASK | LBK_LEN_MODE_MASK |
1715+
LBK_CHAN_MODE_MASK | LPBK_EN_MASK);
17141716
airoha_fe_rmw(eth, REG_GDM_LEN_CFG(2),
17151717
GDM_SHORT_LEN_MASK | GDM_LONG_LEN_MASK,
17161718
FIELD_PREP(GDM_SHORT_LEN_MASK, 60) |

drivers/net/ethernet/airoha/airoha_regs.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,9 @@
151151
#define LPBK_LEN_MASK GENMASK(23, 10)
152152
#define LPBK_CHAN_MASK GENMASK(8, 4)
153153
#define LPBK_MODE_MASK GENMASK(3, 1)
154+
#define LBK_GAP_MODE_MASK BIT(3)
155+
#define LBK_LEN_MODE_MASK BIT(2)
156+
#define LBK_CHAN_MODE_MASK BIT(1)
154157
#define LPBK_EN_MASK BIT(0)
155158

156159
#define REG_GDM_TXCHN_EN(_n) (GDM_BASE(_n) + 0x24)

0 commit comments

Comments
 (0)