Skip to content

Commit f8110cd

Browse files
Darksonnojeda
authored andcommitted
rust: sync: reword the Arc safety comment for Send
The safety comment on `impl Send for Arc` talks about "directly" accessing the value, when it really means "accessing the value with a mutable reference". This commit clarifies that. Suggested-by: Boqun Feng <boqun.feng@gmail.com> Signed-off-by: Alice Ryhl <aliceryhl@google.com> Reviewed-by: Andreas Hindborg <a.hindborg@samsung.com> Reviewed-by: Boqun Feng <boqun.feng@gmail.com> Reviewed-by: Gary Guo <gary@garyguo.net> Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com> Reviewed-by: Benno Lossin <benno.lossin@proton.me> Link: https://lore.kernel.org/r/20230531145939.3714886-2-aliceryhl@google.com Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
1 parent 47329ba commit f8110cd

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

rust/kernel/sync/arc.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,8 @@ impl<T: ?Sized + Unsize<U>, U: ?Sized> core::ops::DispatchFromDyn<Arc<U>> for Ar
146146

147147
// SAFETY: It is safe to send `Arc<T>` to another thread when the underlying `T` is `Sync` because
148148
// it effectively means sharing `&T` (which is safe because `T` is `Sync`); additionally, it needs
149-
// `T` to be `Send` because any thread that has an `Arc<T>` may ultimately access `T` directly, for
150-
// example, when the reference count reaches zero and `T` is dropped.
149+
// `T` to be `Send` because any thread that has an `Arc<T>` may ultimately access `T` using a
150+
// mutable reference when the reference count reaches zero and `T` is dropped.
151151
unsafe impl<T: ?Sized + Sync + Send> Send for Arc<T> {}
152152

153153
// SAFETY: It is safe to send `&Arc<T>` to another thread when the underlying `T` is `Sync` for the

0 commit comments

Comments
 (0)