Input: matrix_keypad - use fsleep for delays after activating columns

Markus Burri · dtor · commit e71087ebcd0e · 2025-02-25T11:22:00.000-08:00
The delay is specified in a device property, so the duration can be arbitrarily large. fsleep() determines the best way of delaying (sleep vs spin) based on duration. see Documentation/timers/delay_sleep_functions.rst Signed-off-by: Markus Burri <markus.burri@mt.com> Reviewed-by: Manuel Traut <manuel.traut@mt.com> Link: https://lore.kernel.org/r/20250110054906.354296-2-markus.burri@mt.com Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
diff --git a/drivers/input/keyboard/matrix_keypad.c b/drivers/input/keyboard/matrix_keypad.c
@@ -69,7 +69,7 @@ static void activate_col(struct matrix_keypad *keypad, int col, bool on)
 	__activate_col(keypad, col, on);
 
 	if (on && keypad->col_scan_delay_us)
-		udelay(keypad->col_scan_delay_us);
+		fsleep(keypad->col_scan_delay_us);
 }
 
 static void activate_all_cols(struct matrix_keypad *keypad, bool on)

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ static void activate_col(struct matrix_keypad *keypad, int col, bool on)`
`69`	`69`	`__activate_col(keypad, col, on);`
`70`	`70`
`71`	`71`	`if (on && keypad->col_scan_delay_us)`
`72`		`- udelay(keypad->col_scan_delay_us);`
	`72`	`+ fsleep(keypad->col_scan_delay_us);`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`static void activate_all_cols(struct matrix_keypad *keypad, bool on)`