platform/x86: thinkpad_acpi: check the return value of devm_mutex_init()

Bartosz Golaszewski · ij-intel · commit e57eabe2fb04 · 2025-03-05T14:14:10.000+02:00
devm_mutex_init() can fail so check its return value. Fixes: 38b9ab8 ("platform/x86: thinkpad_acpi: Move subdriver initialization to tpacpi_pdriver's probe.") Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Link: https://lore.kernel.org/r/20250305103146.53221-1-brgl@bgdev.pl Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
@@ -11849,7 +11849,9 @@ static int __init tpacpi_pdriver_probe(struct platform_device *pdev)
 {
 	int ret;
 
-	devm_mutex_init(&pdev->dev, &tpacpi_inputdev_send_mutex);
+	ret = devm_mutex_init(&pdev->dev, &tpacpi_inputdev_send_mutex);
+	if (ret)
+		return ret;
 
 	tpacpi_inputdev = devm_input_allocate_device(&pdev->dev);
 	if (!tpacpi_inputdev)

Original file line number	Diff line number	Diff line change
`@@ -11849,7 +11849,9 @@ static int __init tpacpi_pdriver_probe(struct platform_device *pdev)`
`11849`	`11849`	`{`
`11850`	`11850`	`int ret;`
`11851`	`11851`
`11852`		`- devm_mutex_init(&pdev->dev, &tpacpi_inputdev_send_mutex);`
	`11852`	`+ ret = devm_mutex_init(&pdev->dev, &tpacpi_inputdev_send_mutex);`
	`11853`	`+ if (ret)`
	`11854`	`+ return ret;`
`11853`	`11855`
`11854`	`11856`	`tpacpi_inputdev = devm_input_allocate_device(&pdev->dev);`
`11855`	`11857`	`if (!tpacpi_inputdev)`