drm/amdgpu: Fix amdgpu_ip_block_hw_fini()

Dan Carpenter · alexdeucher · commit dac64cb3e029 · 2024-10-24T18:07:10.000-04:00
This NULL check is reversed so the function doesn't work. Fixes: dad01f9 ("drm/amdgpu: validate hw_fini before function call") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> Link: https://lore.kernel.org/r/f4fc849e-4e76-4448-8657-caa4c69910b0@stanley.mountain Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -3308,7 +3308,7 @@ static void amdgpu_ip_block_hw_fini(struct amdgpu_ip_block *ip_block)
 {
 	int r;
 
-	if (ip_block->version->funcs->hw_fini) {
+	if (!ip_block->version->funcs->hw_fini) {
 		DRM_ERROR("hw_fini of IP block <%s> not defined\n",
 			  ip_block->version->funcs->name);
 	} else {

Original file line number	Diff line number	Diff line change
`@@ -3308,7 +3308,7 @@ static void amdgpu_ip_block_hw_fini(struct amdgpu_ip_block *ip_block)`
`3308`	`3308`	`{`
`3309`	`3309`	`int r;`
`3310`	`3310`
`3311`		`- if (ip_block->version->funcs->hw_fini) {`
	`3311`	`+ if (!ip_block->version->funcs->hw_fini) {`
`3312`	`3312`	`DRM_ERROR("hw_fini of IP block <%s> not defined\n",`
`3313`	`3313`	`ip_block->version->funcs->name);`
`3314`	`3314`	`} else {`