drm/i915/gt: Prevent uninitialized pointer reads

singh-apoorva1510 · rodrigovivi · commit d6b24cc3e267 · 2025-01-08T08:54:57.000-05:00
Initialize rq to NULL to prevent uninitialized pointer reads. Signed-off-by: Apoorva Singh <apoorva.singh@intel.com> Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20241227112920.1547592-1-apoorva.singh@intel.com Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
diff --git a/drivers/gpu/drm/i915/gt/selftest_migrate.c b/drivers/gpu/drm/i915/gt/selftest_migrate.c
@@ -262,7 +262,7 @@ static int clear(struct intel_migrate *migrate,
 {
 	struct drm_i915_private *i915 = migrate->context->engine->i915;
 	struct drm_i915_gem_object *obj;
-	struct i915_request *rq;
+	struct i915_request *rq = NULL;
 	struct i915_gem_ww_ctx ww;
 	u32 *vaddr, val = 0;
 	bool ccs_cap = false;

Original file line number	Diff line number	Diff line change
`@@ -262,7 +262,7 @@ static int clear(struct intel_migrate *migrate,`
`262`	`262`	`{`
`263`	`263`	`struct drm_i915_private *i915 = migrate->context->engine->i915;`
`264`	`264`	`struct drm_i915_gem_object *obj;`
`265`		`- struct i915_request *rq;`
	`265`	`+ struct i915_request *rq = NULL;`
`266`	`266`	`struct i915_gem_ww_ctx ww;`
`267`	`267`	`u32 *vaddr, val = 0;`
`268`	`268`	`bool ccs_cap = false;`