workqueue: add printf attribute to __alloc_workqueue()

Su Hui · htejun · commit d57212f281fd · 2024-12-24T09:50:38.000-10:00
Fix a compiler warning with W=1: kernel/workqueue.c: error: function ‘__alloc_workqueue’ might be a candidate for ‘gnu_printf’ format attribute[-Werror=suggest-attribute=format] 5657 | name_len = vsnprintf(wq->name, sizeof(wq->name), fmt, args); | ^~~~~~~~ Fixes: 9b59a85 ("workqueue: Don't call va_start / va_end twice") Signed-off-by: Su Hui <suhui@nfschina.com> Signed-off-by: Tejun Heo <tj@kernel.org>
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
@@ -5645,6 +5645,7 @@ static void wq_adjust_max_active(struct workqueue_struct *wq)
 	} while (activated);
 }
 
+__printf(1, 0)
 static struct workqueue_struct *__alloc_workqueue(const char *fmt,
 						  unsigned int flags,
 						  int max_active, va_list args)

Original file line number	Diff line number	Diff line change
`@@ -5645,6 +5645,7 @@ static void wq_adjust_max_active(struct workqueue_struct *wq)`
`5645`	`5645`	`} while (activated);`
`5646`	`5646`	`}`
`5647`	`5647`
	`5648`	`+__printf(1, 0)`
`5648`	`5649`	`static struct workqueue_struct __alloc_workqueue(const char fmt,`
`5649`	`5650`	`unsigned int flags,`
`5650`	`5651`	`int max_active, va_list args)`