ceph: fix cred leak in ceph_mds_check_access()

MaxKellermann · idryomov · commit c5cf42030325 · 2024-11-25T15:51:13.000+01:00
get_current_cred() increments the reference counter, but the put_cred() call was missing. Cc: stable@vger.kernel.org Fixes: 596afb0 ("ceph: add ceph_mds_check_access() helper") Signed-off-by: Max Kellermann <max.kellermann@ionos.com> Reviewed-by: Xiubo Li <xiubli@redhat.com> Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
@@ -5728,6 +5728,7 @@ int ceph_mds_check_access(struct ceph_mds_client *mdsc, char *tpath, int mask)
 
 		err = ceph_mds_auth_match(mdsc, s, cred, tpath);
 		if (err < 0) {
+			put_cred(cred);
 			return err;
 		} else if (err > 0) {
 			/* always follow the last auth caps' permission */
@@ -5743,6 +5744,8 @@ int ceph_mds_check_access(struct ceph_mds_client *mdsc, char *tpath, int mask)
 		}
 	}
 
+	put_cred(cred);
+
 	doutc(cl, "root_squash_perms %d, rw_perms_s %p\n", root_squash_perms,
 	      rw_perms_s);
 	if (root_squash_perms && rw_perms_s == NULL) {

Original file line number	Diff line number	Diff line change
`@@ -5728,6 +5728,7 @@ int ceph_mds_check_access(struct ceph_mds_client mdsc, char tpath, int mask)`
`5728`	`5728`
`5729`	`5729`	`err = ceph_mds_auth_match(mdsc, s, cred, tpath);`
`5730`	`5730`	`if (err < 0) {`
	`5731`	`+ put_cred(cred);`
`5731`	`5732`	`return err;`
`5732`	`5733`	`} else if (err > 0) {`
`5733`	`5734`	`/* always follow the last auth caps' permission */`
`@@ -5743,6 +5744,8 @@ int ceph_mds_check_access(struct ceph_mds_client mdsc, char tpath, int mask)`
`5743`	`5744`	`}`
`5744`	`5745`	`}`
`5745`	`5746`
	`5747`	`+ put_cred(cred);`
	`5748`	`+`
`5746`	`5749`	`doutc(cl, "root_squash_perms %d, rw_perms_s %p\n", root_squash_perms,`
`5747`	`5750`	`rw_perms_s);`
`5748`	`5751`	`if (root_squash_perms && rw_perms_s == NULL) {`