Skip to content

Commit b277fc7

Browse files
kvaneeshmpe
authored andcommitted
powerpc/papr_scm: Update the NUMA distance table for the target node
Platform device helper routines won't update the NUMA distance table while creating a platform device, even if the device is present on a NUMA node that doesn't have memory or CPU. This is especially true for pmem devices. If the target node of the pmem device is not online, we find the nearest online node to the device and associate the pmem device with that online node. To find the nearest online node, we should have the numa distance table updated correctly. Update the distance information during the device probe. For a papr scm device on NUMA node 3 distance_lookup_table value for distance_ref_points_depth = 2 before and after fix is below: Before fix: node 3 distance depth 0 - 0 node 3 distance depth 1 - 0 node 4 distance depth 0 - 4 node 4 distance depth 1 - 2 node 5 distance depth 0 - 5 node 5 distance depth 1 - 1 After fix node 3 distance depth 0 - 3 node 3 distance depth 1 - 1 node 4 distance depth 0 - 4 node 4 distance depth 1 - 2 node 5 distance depth 0 - 5 node 5 distance depth 1 - 1 Without the fix, the nearest numa node to the pmem device (NUMA node 3) will be picked as 4. After the fix, we get the correct numa node which is 5. Fixes: da1115f ("powerpc/nvdimm: Pick nearby online node if the device node is not online") Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://msgid.link/20230404041433.1781804-1-aneesh.kumar@linux.ibm.com
1 parent eca9f6e commit b277fc7

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

arch/powerpc/mm/numa.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -366,6 +366,7 @@ void update_numa_distance(struct device_node *node)
366366
WARN(numa_distance_table[nid][nid] == -1,
367367
"NUMA distance details for node %d not provided\n", nid);
368368
}
369+
EXPORT_SYMBOL_GPL(update_numa_distance);
369370

370371
/*
371372
* ibm,numa-lookup-index-table= {N, domainid1, domainid2, ..... domainidN}

arch/powerpc/platforms/pseries/papr_scm.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1428,6 +1428,13 @@ static int papr_scm_probe(struct platform_device *pdev)
14281428
return -ENODEV;
14291429
}
14301430

1431+
/*
1432+
* open firmware platform device create won't update the NUMA
1433+
* distance table. For PAPR SCM devices we use numa_map_to_online_node()
1434+
* to find the nearest online NUMA node and that requires correct
1435+
* distance table information.
1436+
*/
1437+
update_numa_distance(dn);
14311438

14321439
p = kzalloc(sizeof(*p), GFP_KERNEL);
14331440
if (!p)

0 commit comments

Comments
 (0)