preempt/dynamic: Fix setup_preempt_mode() return value

ahalaney · Peter Zijlstra · commit 9ed20bafc858 · 2021-12-04T10:56:18.000+01:00
__setup() callbacks expect 1 for success and 0 for failure. Correct the usage here to reflect that. Fixes: 826bfeb ("preempt/dynamic: Support dynamic preempt with preempt= boot option") Reported-by: Mark Rutland <mark.rutland@arm.com> Signed-off-by: Andrew Halaney <ahalaney@redhat.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Link: https://lkml.kernel.org/r/20211203233203.133581-1-ahalaney@redhat.com
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
@@ -6617,11 +6617,11 @@ static int __init setup_preempt_mode(char *str)
 	int mode = sched_dynamic_mode(str);
 	if (mode < 0) {
 		pr_warn("Dynamic Preempt: unsupported mode: %s\n", str);
-		return 1;
+		return 0;
 	}
 
 	sched_dynamic_update(mode);
-	return 0;
+	return 1;
 }
 __setup("preempt=", setup_preempt_mode);
 

Original file line number	Diff line number	Diff line change
`@@ -6617,11 +6617,11 @@ static int __init setup_preempt_mode(char *str)`
`6617`	`6617`	`int mode = sched_dynamic_mode(str);`
`6618`	`6618`	`if (mode < 0) {`
`6619`	`6619`	`pr_warn("Dynamic Preempt: unsupported mode: %s\n", str);`
`6620`		`- return 1;`
	`6620`	`+ return 0;`
`6621`	`6621`	`}`
`6622`	`6622`
`6623`	`6623`	`sched_dynamic_update(mode);`
`6624`		`- return 0;`
	`6624`	`+ return 1;`
`6625`	`6625`	`}`
`6626`	`6626`	`__setup("preempt=", setup_preempt_mode);`
`6627`	`6627`