cxl/acpi: Return 'rc' instead of '0' in cxl_parse_cfmws()

leitao · stellarhopper · commit 91019b5bc7c2 · 2023-07-18T11:55:09.000-06:00
Driver initialization returned success (return 0) even if the initialization (cxl_decoder_add() or acpi_table_parse_cedt()) failed. Return the error instead of swallowing it. Fixes: f4ce1f7 ("cxl/acpi: Convert CFMWS parsing to ACPI sub-table helpers") Signed-off-by: Breno Leitao <leitao@debian.org> Link: https://lore.kernel.org/r/20230714093146.2253438-2-leitao@debian.org Reviewed-by: Alison Schofield <alison.schofield@intel.com> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
diff --git a/drivers/cxl/acpi.c b/drivers/cxl/acpi.c
@@ -297,7 +297,7 @@ static int cxl_parse_cfmws(union acpi_subtable_headers *header, void *arg,
 		rc = cxl_decoder_autoremove(dev, cxld);
 	if (rc) {
 		dev_err(dev, "Failed to add decode range: %pr", res);
-		return 0;
+		return rc;
 	}
 	dev_dbg(dev, "add: %s node: %d range [%#llx - %#llx]\n",
 		dev_name(&cxld->dev),

Original file line number	Diff line number	Diff line change
`@@ -297,7 +297,7 @@ static int cxl_parse_cfmws(union acpi_subtable_headers header, void arg,`
`297`	`297`	`rc = cxl_decoder_autoremove(dev, cxld);`
`298`	`298`	`if (rc) {`
`299`	`299`	`dev_err(dev, "Failed to add decode range: %pr", res);`
`300`		`- return 0;`
	`300`	`+ return rc;`
`301`	`301`	`}`
`302`	`302`	`dev_dbg(dev, "add: %s node: %d range [%#llx - %#llx]\n",`
`303`	`303`	`dev_name(&cxld->dev),`