Skip to content

Commit 8eba5b6

Browse files
Uwe Kleine-Königchanwoochoi
authored andcommitted
PM / devfreq: rk3399_dmc: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
1 parent 14532a0 commit 8eba5b6

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/devfreq/rk3399_dmc.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -459,13 +459,11 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)
459459
return ret;
460460
}
461461

462-
static int rk3399_dmcfreq_remove(struct platform_device *pdev)
462+
static void rk3399_dmcfreq_remove(struct platform_device *pdev)
463463
{
464464
struct rk3399_dmcfreq *dmcfreq = dev_get_drvdata(&pdev->dev);
465465

466466
devfreq_event_disable_edev(dmcfreq->edev);
467-
468-
return 0;
469467
}
470468

471469
static const struct of_device_id rk3399dmc_devfreq_of_match[] = {
@@ -476,7 +474,7 @@ MODULE_DEVICE_TABLE(of, rk3399dmc_devfreq_of_match);
476474

477475
static struct platform_driver rk3399_dmcfreq_driver = {
478476
.probe = rk3399_dmcfreq_probe,
479-
.remove = rk3399_dmcfreq_remove,
477+
.remove_new = rk3399_dmcfreq_remove,
480478
.driver = {
481479
.name = "rk3399-dmc-freq",
482480
.pm = &rk3399_dmcfreq_pm,

0 commit comments

Comments
 (0)