phy: tegra: xusb: remove a stray unlock

Dan Carpenter · vinodkoul · commit 83c178470e0b · 2025-05-14T12:21:18.000+01:00
We used to take a lock in tegra186_utmi_bias_pad_power_on() but now we have moved the lock into the caller. Unfortunately, when we moved the lock this unlock was left behind and it results in a double unlock. Delete it now. Fixes: b47158f ("phy: tegra: xusb: Use a bitmask for UTMI pad power state tracking") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Jon Hunter <jonathanh@nvidia.com> Link: https://lore.kernel.org/r/aAjmR6To4EnvRl4G@stanley.mountain Signed-off-by: Vinod Koul <vkoul@kernel.org>
diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/xusb-tegra186.c
@@ -656,8 +656,6 @@ static void tegra186_utmi_bias_pad_power_on(struct tegra_xusb_padctl *padctl)
 	} else {
 		clk_disable_unprepare(priv->usb2_trk_clk);
 	}
-
-	mutex_unlock(&padctl->lock);
 }
 
 static void tegra186_utmi_bias_pad_power_off(struct tegra_xusb_padctl *padctl)

Original file line number	Diff line number	Diff line change
`@@ -656,8 +656,6 @@ static void tegra186_utmi_bias_pad_power_on(struct tegra_xusb_padctl *padctl)`
`656`	`656`	`} else {`
`657`	`657`	`clk_disable_unprepare(priv->usb2_trk_clk);`
`658`	`658`	`}`
`659`		`-`
`660`		`- mutex_unlock(&padctl->lock);`
`661`	`659`	`}`
`662`	`660`
`663`	`661`	`static void tegra186_utmi_bias_pad_power_off(struct tegra_xusb_padctl *padctl)`