ext4: remove unused return value of ext4_mb_release_inode_pa

Kemeng Shi · tytso · commit 820c280896ea · 2024-01-18T10:52:45.000-05:00
Remove unused return value of ext4_mb_release_inode_pa Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> Reviewed-by: Jan Kara <jack@suse.cz> Link: https://lore.kernel.org/r/20240105092102.496631-7-shikemeng@huaweicloud.com Signed-off-by: Theodore Ts'o <tytso@mit.edu>
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
@@ -5307,7 +5307,7 @@ static void ext4_mb_new_preallocation(struct ext4_allocation_context *ac)
  * the caller MUST hold group/inode locks.
  * TODO: optimize the case when there are no in-core structures yet
  */
-static noinline_for_stack int
+static noinline_for_stack void
 ext4_mb_release_inode_pa(struct ext4_buddy *e4b, struct buffer_head *bitmap_bh,
 			struct ext4_prealloc_space *pa)
 {
@@ -5357,8 +5357,6 @@ ext4_mb_release_inode_pa(struct ext4_buddy *e4b, struct buffer_head *bitmap_bh,
 		 */
 	}
 	atomic_add(free, &sbi->s_mb_discarded);
-
-	return 0;
 }
 
 static noinline_for_stack int

Original file line number	Diff line number	Diff line change
`@@ -5307,7 +5307,7 @@ static void ext4_mb_new_preallocation(struct ext4_allocation_context *ac)`
`5307`	`5307`	`* the caller MUST hold group/inode locks.`
`5308`	`5308`	`* TODO: optimize the case when there are no in-core structures yet`
`5309`	`5309`	`*/`
`5310`		`-static noinline_for_stack int`
	`5310`	`+static noinline_for_stack void`
`5311`	`5311`	`ext4_mb_release_inode_pa(struct ext4_buddy e4b, struct buffer_head bitmap_bh,`
`5312`	`5312`	`struct ext4_prealloc_space *pa)`
`5313`	`5313`	`{`
`@@ -5357,8 +5357,6 @@ ext4_mb_release_inode_pa(struct ext4_buddy e4b, struct buffer_head bitmap_bh,`
`5357`	`5357`	`*/`
`5358`	`5358`	`}`
`5359`	`5359`	`atomic_add(free, &sbi->s_mb_discarded);`
`5360`		`-`
`5361`		`- return 0;`
`5362`	`5360`	`}`
`5363`	`5361`
`5364`	`5362`	`static noinline_for_stack int`