Skip to content

Commit 73ea1e9

Browse files
prabhakarladWim Van Sebroeck
authored andcommitted
watchdog: rzv2h: Improve error strings and add newlines
Update rzv2h_wdt_probe() to provide clearer error strings when retrieving the pclk, oscclk, and reset controller, and append missing newline characters to dev_err_probe() and dev_warn() calls for proper log formatting. Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
1 parent 2b20697 commit 73ea1e9

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/watchdog/rzv2h_wdt.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -296,16 +296,16 @@ static int rzv2h_wdt_probe(struct platform_device *pdev)
296296

297297
priv->pclk = devm_clk_get_prepared(dev, "pclk");
298298
if (IS_ERR(priv->pclk))
299-
return dev_err_probe(dev, PTR_ERR(priv->pclk), "no pclk");
299+
return dev_err_probe(dev, PTR_ERR(priv->pclk), "Failed to get pclk\n");
300300

301301
priv->oscclk = devm_clk_get_optional_prepared(dev, "oscclk");
302302
if (IS_ERR(priv->oscclk))
303-
return dev_err_probe(dev, PTR_ERR(priv->oscclk), "no oscclk");
303+
return dev_err_probe(dev, PTR_ERR(priv->oscclk), "Failed to get oscclk\n");
304304

305305
priv->rstc = devm_reset_control_get_optional_exclusive(dev, NULL);
306306
if (IS_ERR(priv->rstc))
307307
return dev_err_probe(dev, PTR_ERR(priv->rstc),
308-
"failed to get cpg reset");
308+
"Failed to get cpg reset\n");
309309

310310
switch (priv->of_data->count_source) {
311311
case COUNT_SOURCE_LOCO:
@@ -343,7 +343,7 @@ static int rzv2h_wdt_probe(struct platform_device *pdev)
343343

344344
ret = watchdog_init_timeout(&priv->wdev, 0, dev);
345345
if (ret)
346-
dev_warn(dev, "Specified timeout invalid, using default");
346+
dev_warn(dev, "Specified timeout invalid, using default\n");
347347

348348
return devm_watchdog_register_device(dev, &priv->wdev);
349349
}

0 commit comments

Comments
 (0)