Skip to content

Commit 7207788

Browse files
geertumarckleinebudde
authored andcommitted
can: rcar_can: Convert to %pe
Replace numerical error codes by mnemotechnic error codes, to improve the user experience in case of errors. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> Link: https://patch.msgid.link/adb2dc49c78b45191de410f645a5e423d341f94e.1755857536.git.geert+renesas@glider.be Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
1 parent 5317225 commit 7207788

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

drivers/net/can/rcar/rcar_can.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -521,20 +521,20 @@ static int rcar_can_open(struct net_device *ndev)
521521
}
522522
err = clk_prepare_enable(priv->can_clk);
523523
if (err) {
524-
netdev_err(ndev, "failed to enable CAN clock, error %d\n",
525-
err);
524+
netdev_err(ndev, "failed to enable CAN clock: %pe\n",
525+
ERR_PTR(err));
526526
goto out_rpm;
527527
}
528528
err = open_candev(ndev);
529529
if (err) {
530-
netdev_err(ndev, "open_candev() failed, error %d\n", err);
530+
netdev_err(ndev, "open_candev() failed %pe\n", ERR_PTR(err));
531531
goto out_can_clock;
532532
}
533533
napi_enable(&priv->napi);
534534
err = request_irq(ndev->irq, rcar_can_interrupt, 0, ndev->name, ndev);
535535
if (err) {
536-
netdev_err(ndev, "request_irq(%d) failed, error %d\n",
537-
ndev->irq, err);
536+
netdev_err(ndev, "request_irq(%d) failed %pe\n", ndev->irq,
537+
ERR_PTR(err));
538538
goto out_close;
539539
}
540540
rcar_can_start(ndev);
@@ -786,8 +786,8 @@ static int rcar_can_probe(struct platform_device *pdev)
786786
}
787787
priv->can_clk = devm_clk_get(dev, clock_names[clock_select]);
788788
if (IS_ERR(priv->can_clk)) {
789+
dev_err(dev, "cannot get CAN clock: %pe\n", priv->can_clk);
789790
err = PTR_ERR(priv->can_clk);
790-
dev_err(dev, "cannot get CAN clock, error %d\n", err);
791791
goto fail_clk;
792792
}
793793

@@ -813,7 +813,7 @@ static int rcar_can_probe(struct platform_device *pdev)
813813

814814
err = register_candev(ndev);
815815
if (err) {
816-
dev_err(dev, "register_candev() failed, error %d\n", err);
816+
dev_err(dev, "register_candev() failed %pe\n", ERR_PTR(err));
817817
goto fail_rpm;
818818
}
819819

0 commit comments

Comments
 (0)