KVM: arm64: Pass on SVE mapping failures

james-c-linaro · oupton · commit 60ad25e14ab5 · 2024-11-12T11:04:39.000-08:00
This function can fail but its return value isn't passed onto the caller. Presumably this could result in a broken state. Fixes: 66d5b53 ("KVM: arm64: Allocate memory mapped at hyp for host sve state in pKVM") Signed-off-by: James Clark <james.clark@linaro.org> Reviewed-by: Fuad Tabba <tabba@google.com> Acked-by: Marc Zyngier <maz@kernel.org> Link: https://lore.kernel.org/r/20241112105604.795809-1-james.clark@linaro.org Signed-off-by: Oliver Upton <oliver.upton@linux.dev>
diff --git a/arch/arm64/kvm/hyp/nvhe/setup.c b/arch/arm64/kvm/hyp/nvhe/setup.c
@@ -146,8 +146,7 @@ static int recreate_hyp_mappings(phys_addr_t phys, unsigned long size,
 			return ret;
 	}
 
-	pkvm_create_host_sve_mappings();
-	return 0;
+	return pkvm_create_host_sve_mappings();
 }
 
 static void update_nvhe_init_params(void)

Original file line number	Diff line number	Diff line change
`@@ -146,8 +146,7 @@ static int recreate_hyp_mappings(phys_addr_t phys, unsigned long size,`
`146`	`146`	`return ret;`
`147`	`147`	`}`
`148`	`148`
`149`		`- pkvm_create_host_sve_mappings();`
`150`		`- return 0;`
	`149`	`+ return pkvm_create_host_sve_mappings();`
`151`	`150`	`}`
`152`	`151`
`153`	`152`	`static void update_nvhe_init_params(void)`