gpio: davinci: Fix condition for irqchip registration

r-vignesh · Bartosz Golaszewski · commit 5a431e50e9d4 · 2024-10-02T12:24:37.000+02:00
Since commit d29e741 ("gpio: davinci: drop platform data support"), irqchip is no longer being registered on platforms what don't use unbanked gpios. Fix this. Reported-by: Sabeeh Khan <sabeeh-khan@ti.com> Fixes: d29e741 ("gpio: davinci: drop platform data support") Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com> Link: https://lore.kernel.org/r/20241002071901.2752757-1-vigneshr@ti.com Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
@@ -472,7 +472,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)
 		return PTR_ERR(clk);
 	}
 
-	if (chips->gpio_unbanked) {
+	if (!chips->gpio_unbanked) {
 		irq = devm_irq_alloc_descs(dev, -1, 0, ngpio, 0);
 		if (irq < 0) {
 			dev_err(dev, "Couldn't allocate IRQ numbers\n");

Original file line number	Diff line number	Diff line change
`@@ -472,7 +472,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)`
`472`	`472`	`return PTR_ERR(clk);`
`473`	`473`	`}`
`474`	`474`
`475`		`- if (chips->gpio_unbanked) {`
	`475`	`+ if (!chips->gpio_unbanked) {`
`476`	`476`	`irq = devm_irq_alloc_descs(dev, -1, 0, ngpio, 0);`
`477`	`477`	`if (irq < 0) {`
`478`	`478`	`dev_err(dev, "Couldn't allocate IRQ numbers\n");`