usb: ulpi: Fix debugfs directory leak

sean-anderson-seco · gregkh · commit 3caf2b2ad733 · 2024-01-27T17:41:42.000-08:00
The ULPI per-device debugfs root is named after the ulpi device's parent, but ulpi_unregister_interface tries to remove a debugfs directory named after the ulpi device itself. This results in the directory sticking around and preventing subsequent (deferred) probes from succeeding. Change the directory name to match the ulpi device. Fixes: bd0a0a0 ("usb: ulpi: Add debugfs support") Cc: stable@vger.kernel.org Signed-off-by: Sean Anderson <sean.anderson@seco.com> Link: https://lore.kernel.org/r/20240126223800.2864613-1-sean.anderson@seco.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c
@@ -301,7 +301,7 @@ static int ulpi_register(struct device *dev, struct ulpi *ulpi)
 		return ret;
 	}
 
-	root = debugfs_create_dir(dev_name(dev), ulpi_root);
+	root = debugfs_create_dir(dev_name(&ulpi->dev), ulpi_root);
 	debugfs_create_file("regs", 0444, root, ulpi, &ulpi_regs_fops);
 
 	dev_dbg(&ulpi->dev, "registered ULPI PHY: vendor %04x, product %04x\n",

Original file line number	Diff line number	Diff line change
`@@ -301,7 +301,7 @@ static int ulpi_register(struct device dev, struct ulpi ulpi)`
`301`	`301`	`return ret;`
`302`	`302`	`}`
`303`	`303`
`304`		`- root = debugfs_create_dir(dev_name(dev), ulpi_root);`
	`304`	`+ root = debugfs_create_dir(dev_name(&ulpi->dev), ulpi_root);`
`305`	`305`	`debugfs_create_file("regs", 0444, root, ulpi, &ulpi_regs_fops);`
`306`	`306`
`307`	`307`	`dev_dbg(&ulpi->dev, "registered ULPI PHY: vendor %04x, product %04x\n",`