Skip to content

Commit 2f22cbb

Browse files
committed
rust: types: Make Opaque::get const
To support a potential usage: static foo: Opaque<Foo> = ..; // Or defined in an extern block. ... fn bar() { let ptr = foo.get(); } `Opaque::get` need to be `const`, otherwise compiler will complain because calls on statics are limited to const functions. Also `Opaque::get` should be naturally `const` since it's a composition of two `const` functions: `UnsafeCell::get` and `ptr::cast`. Reviewed-by: Wedson Almeida Filho <walmeida@microsoft.com> Reviewed-by: Alice Ryhl <aliceryhl@google.com> Reviewed-by: Benno Lossin <benno.lossin@proton.me> Link: https://lore.kernel.org/r/20240401214543.1242286-1-boqun.feng@gmail.com Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
1 parent 4f756c2 commit 2f22cbb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

rust/kernel/types.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ impl<T> Opaque<T> {
315315
}
316316

317317
/// Returns a raw pointer to the opaque data.
318-
pub fn get(&self) -> *mut T {
318+
pub const fn get(&self) -> *mut T {
319319
UnsafeCell::get(&self.value).cast::<T>()
320320
}
321321

0 commit comments

Comments
 (0)