crypto: api - Call crypto_alg_put in crypto_unregister_alg

herbertx · herbertx · commit 27b13425349e · 2025-03-21T17:39:06.000+08:00
Instead of calling cra_destroy by hand, call it through crypto_alg_put so that the correct unwinding functions are called through crypto_destroy_alg. Fixes: 3d6979b ("crypto: api - Add cra_type->destroy hook") Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/crypto/algapi.c b/crypto/algapi.c
@@ -464,8 +464,7 @@ void crypto_unregister_alg(struct crypto_alg *alg)
 	if (WARN_ON(refcount_read(&alg->cra_refcnt) != 1))
 		return;
 
-	if (alg->cra_destroy)
-		alg->cra_destroy(alg);
+	crypto_alg_put(alg);
 
 	crypto_remove_final(&list);
 }

Original file line number	Diff line number	Diff line change
`@@ -464,8 +464,7 @@ void crypto_unregister_alg(struct crypto_alg *alg)`
`464`	`464`	`if (WARN_ON(refcount_read(&alg->cra_refcnt) != 1))`
`465`	`465`	`return;`
`466`	`466`
`467`		`- if (alg->cra_destroy)`
`468`		`- alg->cra_destroy(alg);`
	`467`	`+ crypto_alg_put(alg);`
`469`	`468`
`470`	`469`	`crypto_remove_final(&list);`
`471`	`470`	`}`