scsi: aha152x: Use DECLARE_COMPLETION_ONSTACK for non-constant completion

ZhongqiuHan-Qcom · martinkpetersen · commit 23cef42d1741 · 2024-07-10T22:51:44.000-04:00
The _ONSTACK variant should be used for on-stack completion, otherwise it will break lockdep. See also commit 6e9a473 ("[PATCH] completions: lockdep annotate on stack completions"). Signed-off-by: Zhongqiu Han <quic_zhonhan@quicinc.com> Link: https://lore.kernel.org/r/20240705103614.3650637-1-quic_zhonhan@quicinc.com Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/aha152x.c b/drivers/scsi/aha152x.c
@@ -1072,7 +1072,7 @@ static int aha152x_abort(struct scsi_cmnd *SCpnt)
 static int aha152x_device_reset(struct scsi_cmnd * SCpnt)
 {
 	struct Scsi_Host *shpnt = SCpnt->device->host;
-	DECLARE_COMPLETION(done);
+	DECLARE_COMPLETION_ONSTACK(done);
 	int ret, issued, disconnected;
 	unsigned char old_cmd_len = SCpnt->cmd_len;
 	unsigned long flags;

Original file line number	Diff line number	Diff line change
`@@ -1072,7 +1072,7 @@ static int aha152x_abort(struct scsi_cmnd *SCpnt)`
`1072`	`1072`	`static int aha152x_device_reset(struct scsi_cmnd * SCpnt)`
`1073`	`1073`	`{`
`1074`	`1074`	`struct Scsi_Host *shpnt = SCpnt->device->host;`
`1075`		`- DECLARE_COMPLETION(done);`
	`1075`	`+ DECLARE_COMPLETION_ONSTACK(done);`
`1076`	`1076`	`int ret, issued, disconnected;`
`1077`	`1077`	`unsigned char old_cmd_len = SCpnt->cmd_len;`
`1078`	`1078`	`unsigned long flags;`