leds: led-test: Remove standard error checking after KUNIT_ASSERT_*()

lag-linaro · lag-linaro · commit 1d7f25483c87 · 2025-05-14T09:25:05.000+01:00
If a KUNIT_ASSERT_*() call ends up in an assertion, the test is marked as a failure and the subsequent error checking is never executed, making it superfluous. Remove it for simplicity and to avoid confusion. Link: https://lore.kernel.org/r/20250501081918.3621432-1-lee@kernel.org Signed-off-by: Lee Jones <lee@kernel.org>
diff --git a/drivers/leds/led-test.c b/drivers/leds/led-test.c
@@ -26,8 +26,6 @@ static void led_test_class_register(struct kunit *test)
 
 	ret = devm_led_classdev_register(dev, cdev);
 	KUNIT_ASSERT_EQ(test, ret, 0);
-	if (ret)
-		return;
 }
 
 static struct kunit_case led_test_cases[] = {

Original file line number	Diff line number	Diff line change
`@@ -26,8 +26,6 @@ static void led_test_class_register(struct kunit *test)`
`26`	`26`
`27`	`27`	`ret = devm_led_classdev_register(dev, cdev);`
`28`	`28`	`KUNIT_ASSERT_EQ(test, ret, 0);`
`29`		`- if (ret)`
`30`		`- return;`
`31`	`29`	`}`
`32`	`30`
`33`	`31`	`static struct kunit_case led_test_cases[] = {`