gpio: graniterapids: Fix GPIO Ack functionality

aborzesz · Bartosz Golaszewski · commit 0bb18e34abdd · 2024-12-10T10:35:13.000+01:00
Interrupt status (GPI_IS) register is cleared by writing 1 to it, not 0. Cc: stable@vger.kernel.org Signed-off-by: Alan Borzeszkowski <alan.borzeszkowski@linux.intel.com> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> Acked-by: Andy Shevchenko <andy@kernel.org> Link: https://lore.kernel.org/r/20241204070415.1034449-8-mika.westerberg@linux.intel.com Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
diff --git a/drivers/gpio/gpio-graniterapids.c b/drivers/gpio/gpio-graniterapids.c
@@ -185,7 +185,7 @@ static void gnr_gpio_irq_ack(struct irq_data *d)
 	guard(raw_spinlock_irqsave)(&priv->lock);
 
 	reg = readl(addr);
-	reg &= ~BIT(bit_idx);
+	reg |= BIT(bit_idx);
 	writel(reg, addr);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -185,7 +185,7 @@ static void gnr_gpio_irq_ack(struct irq_data *d)`
`185`	`185`	`guard(raw_spinlock_irqsave)(&priv->lock);`
`186`	`186`
`187`	`187`	`reg = readl(addr);`
`188`		`- reg &= ~BIT(bit_idx);`
	`188`	`+ reg \|= BIT(bit_idx);`
`189`	`189`	`writel(reg, addr);`
`190`	`190`	`}`
`191`	`191`