proper TestMetadata constructor functions

Author: Firestar99

tests/difftests/README.md

@@ -77,11 +77,7 @@ fn main() {
     file.write_all(&output).expect("Failed to write output");
 
     // Optional: Write metadata for floating-point comparison
-    let metadata = TestMetadata {
-        epsilon: Some(0.00001),  // Allow differences up to 1e-5
-        output_type: OutputType::F32,  // Interpret output as f32 array
-    };
-    config.write_metadata(&metadata).expect("Failed to write metadata");
+    config.write_metadata(&TestMetadata::f32(0.00001)).expect("Failed to write metadata");
 }
 ```
 
@@ -130,15 +126,16 @@ outputs:
 use difftest::config::{TestMetadata, OutputType};
 
 // Write metadata before or after writing output
+let metadata = TestMetadata::f32(0.00001); // output is f32 with some epsilon
+config.write_metadata(&metadata)?;
+
+// Alternative: Construct TestMetadata yourself 
 let metadata = TestMetadata {
-    epsilon: Some(0.00001),        // Maximum allowed difference (default: None)
+    epsilon: Some(0.00001),        // Maximum allowed epsilon / difference (default: None)
     output_type: OutputType::F32,  // How to interpret output data (default: Raw)
+    ..TestMetadata::default()
 };
 config.write_metadata(&metadata)?;
-
-// Alternative: Use the helper method for common cases
-let metadata = TestMetadata::with_epsilon(0.00001);  // Sets epsilon, keeps default output_type
-config.write_metadata(&metadata)?;
 ```
 
 **Metadata fields:**

tests/difftests/lib/src/config.rs

@@ -51,13 +51,47 @@ pub enum OutputType {
 }
 
 impl TestMetadata {
-    /// Create metadata with a specific epsilon value, keeping default output type
-    pub fn with_epsilon(epsilon: f32) -> Self {
+    /// Create metadata for f32 with some epsilon value
+    pub fn f32(epsilon: f32) -> Self {
         Self {
+            output_type: OutputType::F32,
             epsilon: Some(epsilon),
             ..Default::default()
         }
     }
+
+    /// Create metadata for f64 with some epsilon value
+    pub fn f64(epsilon: f32) -> Self {
+        Self {
+            output_type: OutputType::F64,
+            epsilon: Some(epsilon),
+            ..Default::default()
+        }
+    }
+
+    /// Create metadata for u32
+    pub fn u32() -> Self {
+        Self {
+            output_type: OutputType::U32,
+            ..Default::default()
+        }
+    }
+
+    /// Create metadata for i32
+    pub fn i32() -> Self {
+        Self {
+            output_type: OutputType::I32,
+            ..Default::default()
+        }
+    }
+
+    /// Create metadata for raw hex values
+    pub fn raw() -> Self {
+        Self {
+            output_type: OutputType::Raw,
+            ..Default::default()
+        }
+    }
 }
 
 impl Config {

tests/difftests/tests/arch/workgroup_memory/workgroup_memory-ash/src/main.rs

@@ -49,12 +49,9 @@ fn main() {
         .unwrap();
 
         // Write metadata for U32 comparison
-        let metadata = difftest::config::TestMetadata {
-            epsilon: None,
-            output_type: difftest::config::OutputType::U32,
-            ..Default::default()
-        };
-        config.write_metadata(&metadata).unwrap();
+        config
+            .write_metadata(&difftest::config::TestMetadata::u32())
+            .unwrap();
 
         test.run_test(&config).unwrap();
     }

tests/difftests/tests/arch/workgroup_memory/workgroup_memory-rust/src/main.rs

@@ -31,12 +31,9 @@ fn main() {
     );
 
     // Write metadata for U32 comparison
-    let metadata = difftest::config::TestMetadata {
-        epsilon: None,
-        output_type: difftest::config::OutputType::U32,
-        ..Default::default()
-    };
-    config.write_metadata(&metadata).unwrap();
+    config
+        .write_metadata(&difftest::config::TestMetadata::u32())
+        .unwrap();
 
     test.run_test(&config).unwrap();
 }

tests/difftests/tests/arch/workgroup_memory/workgroup_memory-wgsl/src/main.rs

@@ -30,12 +30,9 @@ fn main() {
     );
 
     // Write metadata for U32 comparison
-    let metadata = difftest::config::TestMetadata {
-        epsilon: None,
-        output_type: difftest::config::OutputType::U32,
-        ..Default::default()
-    };
-    config.write_metadata(&metadata).unwrap();
+    config
+        .write_metadata(&difftest::config::TestMetadata::u32())
+        .unwrap();
 
     test.run_test(&config).unwrap();
 }

tests/difftests/tests/lang/core/ops/math_ops/math_ops-rust/src/main.rs

@@ -52,12 +52,9 @@ fn main() {
     );
 
     // Write metadata file
-    let metadata = difftest::config::TestMetadata {
-        epsilon: Some(2e-6), // Small epsilon for last-bit differences
-        output_type: difftest::config::OutputType::F32,
-        ..Default::default()
-    };
-    config.write_metadata(&metadata).unwrap();
+    config
+        .write_metadata(&difftest::config::TestMetadata::f32(2e-6))
+        .unwrap();
 
     test.run_test(&config).unwrap();
 }

tests/difftests/tests/lang/core/ops/math_ops/math_ops-wgsl/src/main.rs

@@ -51,12 +51,9 @@ fn main() {
     );
 
     // Write metadata file
-    let metadata = difftest::config::TestMetadata {
-        epsilon: Some(2e-6), // Small epsilon for last-bit differences
-        output_type: difftest::config::OutputType::F32,
-        ..Default::default()
-    };
-    config.write_metadata(&metadata).unwrap();
+    config
+        .write_metadata(&difftest::config::TestMetadata::f32(2e-6))
+        .unwrap();
 
     test.run_test(&config).unwrap();
 }

tests/difftests/tests/lang/core/ops/matrix_ops/matrix_ops-rust/src/main.rs

@@ -52,12 +52,10 @@ fn main() {
     );
 
     // Write metadata file
-    let metadata = difftest::config::TestMetadata {
-        epsilon: Some(2e-5),
-        output_type: difftest::config::OutputType::F32,
-        ..Default::default()
-    };
-    config.write_metadata(&metadata).unwrap();
+    // this one requires higher epsilon, noticed on an RDNA2 680M (Ryzen iGPU) with radv
+    config
+        .write_metadata(&difftest::config::TestMetadata::f32(2e-5))
+        .unwrap();
 
     test.run_test(&config).unwrap();
 }

tests/difftests/tests/lang/core/ops/matrix_ops/matrix_ops-wgsl/src/main.rs

@@ -51,12 +51,9 @@ fn main() {
     );
 
     // Write metadata file
-    let metadata = difftest::config::TestMetadata {
-        epsilon: Some(2e-5),
-        output_type: difftest::config::OutputType::F32,
-        ..Default::default()
-    };
-    config.write_metadata(&metadata).unwrap();
+    config
+        .write_metadata(&difftest::config::TestMetadata::f32(2e-5))
+        .unwrap();
 
     test.run_test(&config).unwrap();
 }

tests/difftests/tests/lang/core/ops/vector_ops/vector_ops-rust/src/main.rs

@@ -52,12 +52,9 @@ fn main() {
     );
 
     // Write metadata file
-    let metadata = difftest::config::TestMetadata {
-        epsilon: Some(1e-5), // 1e-5 - appropriate for 5 decimal place rounding
-        output_type: difftest::config::OutputType::F32,
-        ..Default::default()
-    };
-    config.write_metadata(&metadata).unwrap();
+    config
+        .write_metadata(&difftest::config::TestMetadata::f32(1e-5))
+        .unwrap();
 
     test.run_test(&config).unwrap();
 }