Add .json extension to base_file_name attr and check target dir existance;

Author: hans-thomas

src/Drivers/BaseDriver.php

@@ -10,11 +10,7 @@ abstract class BaseDriver implements SwaggerDriverContract
 
     public function __construct()
     {
-        $prodDir = config('auto-doc.documentation_directory');
-        if (!is_dir($prodDir)) {
-            mkdir($prodDir);
-        }
-        $this->tempFilePath = $prodDir.DIRECTORY_SEPARATOR.'temp_documentation.json';
+        $this->tempFilePath = storage_path('temp_documentation.json');
     }
 
     public function saveTmpData($data): void

src/Drivers/LocalDriver.php

@@ -7,32 +7,45 @@
 
 class LocalDriver extends BaseDriver
 {
-    protected ?string $prodFilePath;
+    protected ?string $baseFileName;
+    private ?array $config;
 
     public function __construct()
     {
         parent::__construct();
-        $this->prodFilePath = config('auto-doc.documentation_directory').DIRECTORY_SEPARATOR.config('auto-doc.drivers.local.production_path');
+        $this->config = config('auto-doc.drivers.local');
 
-        if (!preg_match('/\/[\w]+\.json/ms',$this->prodFilePath)) {
+        $directory = $this->config['directory'];
+        if (!str_ends_with($directory, DIRECTORY_SEPARATOR)) {
+            $directory .= DIRECTORY_SEPARATOR;
+        }
+
+        $this->baseFileName = storage_path($directory.$this->config['base_file_name'].'.json');
+
+        if (!preg_match('/\/[\w]+\.json/ms', $this->baseFileName)) {
             throw new MissedProductionFilePathException();
         }
     }
 
     public function saveData(): void
     {
-        file_put_contents($this->prodFilePath, json_encode($this->getTmpData()));
+        $prodDir = storage_path($this->config['directory']);
+        if (!is_dir($prodDir)) {
+            mkdir($prodDir);
+        }
+
+        file_put_contents($this->baseFileName, json_encode($this->getTmpData()));
 
         $this->clearTmpData();
     }
 
     public function getDocumentation(): array
     {
-        if (!file_exists($this->prodFilePath)) {
+        if (!file_exists($this->baseFileName)) {
             throw new FileNotFoundException();
         }
 
-        $fileContent = file_get_contents($this->prodFilePath);
+        $fileContent = file_get_contents($this->baseFileName);
 
         return json_decode($fileContent, true);
     }

src/Drivers/StorageDriver.php

@@ -10,34 +10,40 @@
 class StorageDriver extends BaseDriver
 {
     protected Filesystem $disk;
-    protected ?string $prodFilePath;
+    protected ?string $baseFileName;
+    protected array $config;
 
     public function __construct()
     {
         parent::__construct();
 
-        $this->disk = Storage::disk(config('auto-doc.drivers.storage.disk'));
-        $this->prodFilePath = config('auto-doc.drivers.storage.production_path');
+        $this->config = config('auto-doc.drivers.storage');
+        $this->disk = Storage::disk($this->config['disk']);
+        $directory = $this->config['directory'];
+        if (!str_ends_with($directory, DIRECTORY_SEPARATOR)) {
+            $directory .= DIRECTORY_SEPARATOR;
+        }
+        $this->baseFileName = $directory.$this->config['base_file_name'].'.json';
 
-        if (empty($this->prodFilePath)) {
+        if (!preg_match('/\/[\w]+\.json/ms', $this->baseFileName)) {
             throw new MissedProductionFilePathException();
         }
     }
 
     public function saveData(): void
     {
-        $this->disk->put($this->prodFilePath, json_encode($this->getTmpData()));
+        $this->disk->put($this->baseFileName, json_encode($this->getTmpData()));
 
         $this->clearTmpData();
     }
 
     public function getDocumentation(): array
     {
-        if (!$this->disk->exists($this->prodFilePath)) {
+        if (!$this->disk->exists($this->baseFileName)) {
             throw new FileNotFoundException();
         }
 
-        $fileContent = $this->disk->get($this->prodFilePath);
+        $fileContent = $this->disk->get($this->baseFileName);
 
         return json_decode($fileContent, true);
     }