From 979e975ac3059416bdc7d85adf5aa09136eea9aa Mon Sep 17 00:00:00 2001 From: Minggang Wang Date: Tue, 3 Jun 2025 10:25:27 +0800 Subject: [PATCH 1/9] Enable npm test on Windows workflow --- .github/workflows/windows-build-and-test.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/windows-build-and-test.yml b/.github/workflows/windows-build-and-test.yml index f4cba976..b484ca44 100644 --- a/.github/workflows/windows-build-and-test.yml +++ b/.github/workflows/windows-build-and-test.yml @@ -64,3 +64,4 @@ jobs: run: | set RMW_IMPLEMENTATION=rmw_fastrtps_cpp call "c:\dev\${{ matrix.ros_distribution }}\ros2-windows\setup.bat" + npm test From 4ff254cb7bd73f27fdb273d23adaaf7bc2bbe427 Mon Sep 17 00:00:00 2001 From: Minggang Wang Date: Tue, 3 Jun 2025 10:44:04 +0800 Subject: [PATCH 2/9] Address comment --- .github/workflows/windows-build-and-test.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/windows-build-and-test.yml b/.github/workflows/windows-build-and-test.yml index b484ca44..10659d7b 100644 --- a/.github/workflows/windows-build-and-test.yml +++ b/.github/workflows/windows-build-and-test.yml @@ -53,7 +53,6 @@ jobs: - name: Build rclnodejs shell: cmd run: | - set RMW_IMPLEMENTATION=rmw_fastrtps_cpp call "c:\dev\${{ matrix.ros_distribution }}\ros2-windows\setup.bat" npm i @@ -62,6 +61,6 @@ jobs: - name: Test rclnodejs shell: cmd run: | - set RMW_IMPLEMENTATION=rmw_fastrtps_cpp + set RMW_IMPLEMENTATION=rmw_cyclonedds_cpp call "c:\dev\${{ matrix.ros_distribution }}\ros2-windows\setup.bat" npm test From 9c881154b45ebd3e0fae9ba61230bba7c2e2614c Mon Sep 17 00:00:00 2001 From: Minggang Wang Date: Tue, 3 Jun 2025 10:58:12 +0800 Subject: [PATCH 3/9] Address comments --- .github/workflows/windows-build-and-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/windows-build-and-test.yml b/.github/workflows/windows-build-and-test.yml index 10659d7b..4b6973ee 100644 --- a/.github/workflows/windows-build-and-test.yml +++ b/.github/workflows/windows-build-and-test.yml @@ -63,4 +63,4 @@ jobs: run: | set RMW_IMPLEMENTATION=rmw_cyclonedds_cpp call "c:\dev\${{ matrix.ros_distribution }}\ros2-windows\setup.bat" - npm test + cmd /c "set RMW_IMPLEMENTATION=rmw_cyclonedds_cpp&&npm test" From 8588d145061f55613825184e9bd644904c8e418a Mon Sep 17 00:00:00 2001 From: Minggang Wang Date: Tue, 3 Jun 2025 11:16:07 +0800 Subject: [PATCH 4/9] Address comments --- .github/workflows/windows-build-and-test.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/windows-build-and-test.yml b/.github/workflows/windows-build-and-test.yml index 4b6973ee..c7cf0018 100644 --- a/.github/workflows/windows-build-and-test.yml +++ b/.github/workflows/windows-build-and-test.yml @@ -61,6 +61,5 @@ jobs: - name: Test rclnodejs shell: cmd run: | - set RMW_IMPLEMENTATION=rmw_cyclonedds_cpp call "c:\dev\${{ matrix.ros_distribution }}\ros2-windows\setup.bat" - cmd /c "set RMW_IMPLEMENTATION=rmw_cyclonedds_cpp&&npm test" + cmd /c "set RMW_IMPLEMENTATION=rmw_fastrtps_cpp&&npm test" From 67f3b8e5a1593827f02d0d4b8df54a3daca980f6 Mon Sep 17 00:00:00 2001 From: Minggang Wang Date: Tue, 3 Jun 2025 11:37:33 +0800 Subject: [PATCH 5/9] Address comments --- .github/workflows/windows-build-and-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/windows-build-and-test.yml b/.github/workflows/windows-build-and-test.yml index c7cf0018..8b12964b 100644 --- a/.github/workflows/windows-build-and-test.yml +++ b/.github/workflows/windows-build-and-test.yml @@ -54,7 +54,7 @@ jobs: shell: cmd run: | call "c:\dev\${{ matrix.ros_distribution }}\ros2-windows\setup.bat" - npm i + cmd /c "set RMW_IMPLEMENTATION=rmw_fastrtps_cpp&&npm i" # On the windows/foxy combination the Eclipse CycloneDDS RMW implementation is used to workaround # an error when loading the default fastrtps ddl From 505587950c344efcd1ca62eeb3bafdf4f2324614 Mon Sep 17 00:00:00 2001 From: Minggang Wang Date: Tue, 3 Jun 2025 12:51:13 +0800 Subject: [PATCH 6/9] Address comments --- .github/workflows/windows-build-and-test.yml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/windows-build-and-test.yml b/.github/workflows/windows-build-and-test.yml index 8b12964b..9c4cc2b5 100644 --- a/.github/workflows/windows-build-and-test.yml +++ b/.github/workflows/windows-build-and-test.yml @@ -45,16 +45,13 @@ jobs: wget --quiet https://ci.ros2.org/view/packaging/job/packaging_windows/lastSuccessfulBuild/artifact/ws/ros2-package-windows-AMD64.zip -O rolling.zip 7z x rolling.zip -y -o/c/dev/rolling - - name: Prebuild - Setup VS Dev Environment - uses: seanmiddleditch/gha-setup-vsdevenv@v4 - - uses: actions/checkout@v4 - name: Build rclnodejs shell: cmd run: | call "c:\dev\${{ matrix.ros_distribution }}\ros2-windows\setup.bat" - cmd /c "set RMW_IMPLEMENTATION=rmw_fastrtps_cpp&&npm i" + npm i # On the windows/foxy combination the Eclipse CycloneDDS RMW implementation is used to workaround # an error when loading the default fastrtps ddl @@ -62,4 +59,4 @@ jobs: shell: cmd run: | call "c:\dev\${{ matrix.ros_distribution }}\ros2-windows\setup.bat" - cmd /c "set RMW_IMPLEMENTATION=rmw_fastrtps_cpp&&npm test" + cmd /c "set RMW_IMPLEMENTATION=rmw_fastrtps_cpp & &npm test" From 9293a4e84a3bafdd11b13f4bdf85d352667fc39b Mon Sep 17 00:00:00 2001 From: Minggang Wang Date: Fri, 6 Jun 2025 12:40:02 +0800 Subject: [PATCH 7/9] Address comments --- .github/workflows/windows-build-and-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/windows-build-and-test.yml b/.github/workflows/windows-build-and-test.yml index 9c4cc2b5..933d50b1 100644 --- a/.github/workflows/windows-build-and-test.yml +++ b/.github/workflows/windows-build-and-test.yml @@ -59,4 +59,4 @@ jobs: shell: cmd run: | call "c:\dev\${{ matrix.ros_distribution }}\ros2-windows\setup.bat" - cmd /c "set RMW_IMPLEMENTATION=rmw_fastrtps_cpp & &npm test" + cmd /c "set RMW_IMPLEMENTATION=rmw_fastrtps_cpp && ros2 run demo_nodes_cpp talker" From dfb3b243e1b59ad7adf35ac4aba5ecc58ba72903 Mon Sep 17 00:00:00 2001 From: Minggang Wang Date: Fri, 27 Jun 2025 17:34:07 +0800 Subject: [PATCH 8/9] Run demo only --- .github/workflows/windows-build-and-test.yml | 27 ++------------------ 1 file changed, 2 insertions(+), 25 deletions(-) diff --git a/.github/workflows/windows-build-and-test.yml b/.github/workflows/windows-build-and-test.yml index 933d50b1..c46b5bc0 100644 --- a/.github/workflows/windows-build-and-test.yml +++ b/.github/workflows/windows-build-and-test.yml @@ -21,42 +21,19 @@ jobs: strategy: fail-fast: false matrix: - node-version: [22.X] ros_distribution: - humble - jazzy - kilted - rolling steps: - - name: Setup Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v4 - with: - node-version: ${{ matrix.node-version }} - - name: Setup ROS2 uses: ros-tooling/setup-ros@v0.7 with: required-ros-distributions: ${{ matrix.ros_distribution }} - - name: Install ROS2 Rolling (Conditional) - if: ${{ matrix.ros_distribution == 'rolling' }} - shell: bash - run: | - wget --quiet https://ci.ros2.org/view/packaging/job/packaging_windows/lastSuccessfulBuild/artifact/ws/ros2-package-windows-AMD64.zip -O rolling.zip - 7z x rolling.zip -y -o/c/dev/rolling - - - uses: actions/checkout@v4 - - - name: Build rclnodejs - shell: cmd - run: | - call "c:\dev\${{ matrix.ros_distribution }}\ros2-windows\setup.bat" - npm i - - # On the windows/foxy combination the Eclipse CycloneDDS RMW implementation is used to workaround - # an error when loading the default fastrtps ddl - - name: Test rclnodejs + - name: Run demo shell: cmd run: | call "c:\dev\${{ matrix.ros_distribution }}\ros2-windows\setup.bat" - cmd /c "set RMW_IMPLEMENTATION=rmw_fastrtps_cpp && ros2 run demo_nodes_cpp talker" + cmd /c "ros2 run demo_nodes_cpp talker" From 90720ad95f5c66825374782448dd5a4919ec4ba2 Mon Sep 17 00:00:00 2001 From: Minggang Wang Date: Thu, 3 Jul 2025 15:37:50 +0800 Subject: [PATCH 9/9] Pump to windows-2025 --- .github/workflows/windows-build-and-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/windows-build-and-test.yml b/.github/workflows/windows-build-and-test.yml index c46b5bc0..ac0623ea 100644 --- a/.github/workflows/windows-build-and-test.yml +++ b/.github/workflows/windows-build-and-test.yml @@ -17,7 +17,7 @@ on: jobs: build: - runs-on: windows-2019 + runs-on: windows-2025 strategy: fail-fast: false matrix: