fix(instrumentation): TRACE_DISABLE_INSTRUMENTATIONS does not set default values

Author: gergelyke

lib/agent/api/index.spec.js

@@ -59,9 +59,12 @@ describe('The Trace CollectorApi module', function () {
   })
 
   it('can be instantiated w/ serviceName and apiKey', function () {
+    CollectorApi.create(defaultConfig)
+  })
+
+  it('can use a proxy', function () {
     var httpsRequestSpy = this.sandbox.spy(https, 'request')
     defaultConfig.proxy = 'http://127.0.0.1'
-    var collectorApi = CollectorApi.create(defaultConfig)
 
     var serviceKey = 12
 
@@ -71,9 +74,6 @@ describe('The Trace CollectorApi module', function () {
       pid: 7777
     }
 
-    var path = util.format(defaultConfig.collectorApiRpmMetricsEndpoint, serviceKey)
-    var sendUrl = url.resolve(defaultConfig.collectorApiUrl, path)
-
     var collectorApi = CollectorApi.create(defaultConfig)
     collectorApi.serviceKey = serviceKey
 
@@ -83,10 +83,6 @@ describe('The Trace CollectorApi module', function () {
     expect(collectorApi.proxyAgent).to.be.ok
   })
 
-  it('can use a proxy', function () {
-    var collectorApi = CollectorApi.create(defaultConfig)
-  })
-
   it('sends rpm metrics to the collector server', function () {
     var serviceKey = 12
 

lib/agent/metrics/custom/index.js

@@ -1,5 +1,3 @@
-var debug = require('debug')('risingstack/trace')
-
 var Timer = require('../../timer')
 
 function CustomMetrics (options) {

lib/utils/configReader.js

@@ -62,7 +62,7 @@ ConfigReader.prototype._getEnvVarConfig = function () {
     disableStackTrace: process.env.TRACE_DISABLE_STACK_TRACE == true, // eslint-disable-line
     disableInstrumentations: process.env.TRACE_DISABLE_INSTRUMENTATIONS
       ? process.env.TRACE_DISABLE_INSTRUMENTATIONS.split(',')
-      : [],
+      : undefined,
     proxy: process.env.TRACE_PROXY
   }
 

lib/utils/configReader.spec.js

@@ -357,7 +357,7 @@ describe('Config Reader module', function () {
 
         var config = configReader.getConfig()
 
-        expect(config.disableInstrumentations).to.eql([])
+        expect(config.disableInstrumentations).to.eql(undefined)
       })
 
       it('parses list from environment variable', function () {