cmake:BLACS: modern C compilers need no-implicit flag to avoid error

Author: scivision

.github/workflows/cmake.yml

@@ -208,12 +208,13 @@ jobs:
     - name: Checkout ScaLAPACK
       uses: actions/checkout@v3
 
-    - name: Setup MPI
-      run: brew install open-mpi
+    - name: Setup MPI, Ninja
+      run: brew install open-mpi ninja
 
     - name: CMake configuration
       run: >
         cmake -B build
+        -G Ninja
         --install-prefix ${{ runner.temp }}
         -DBUILD_SINGLE=on -DBUILD_DOUBLE=off -DBUILD_COMPLEX=off -DBUILD_COMPLEX16=off
         -DMPIEXEC_PREFLAGS=${{ env.MPIEXEC_PREFLAGS }}

BLACS/TESTING/CMakeLists.txt

@@ -8,7 +8,7 @@ set(FTestObj
    blacstest.f btprim.f tools.f)
 
 if (CMAKE_Fortran_COMPILER_ID STREQUAL "GNU" AND CMAKE_Fortran_COMPILER_VERSION VERSION_GREATER_EQUAL 10)
-  set_source_files_properties(blacstest.f PROPERTIES COMPILE_FLAGS "-std=legacy")
+  set_property(SOURCE blacstest.f PROPERTY COMPILE_FLAGS "-std=legacy")
 endif()
 
 add_executable(xFbtest ${FTestObj})

CMakeLists.txt

@@ -26,11 +26,11 @@ configure_file(
 # Add the CMake directory for custon CMake modules
 set(CMAKE_MODULE_PATH "${SCALAPACK_SOURCE_DIR}/CMAKE" ${CMAKE_MODULE_PATH})
 
-if (UNIX)
-   if ("${CMAKE_Fortran_COMPILER_ID}" STREQUAL "Intel")
-      set( CMAKE_Fortran_FLAGS "${CMAKE_Fortran_FLAGS} -fltconsistency -fp_port" )
-   endif ()
-endif ()
+if(UNIX)
+  if(CMAKE_Fortran_COMPILER_ID STREQUAL "Intel")
+    add_compile_options("$<$<COMPILE_LANGUAGE:Fortran>:-fltconsistency;-fp_port>")
+  endif()
+endif()
 
 #
 #   MPI
@@ -85,12 +85,6 @@ else()
 endif()
 
 
-if (UNIX)
-   if ("${CMAKE_Fortran_COMPILER_ID}" STREQUAL "Intel")
-      set( CMAKE_Fortran_FLAGS "${CMAKE_Fortran_FLAGS} -fltconsistency -fp_port" )
-   endif ()
-endif ()
-
 macro(SCALAPACK_install_library lib)
   install(TARGETS ${lib} EXPORT scalapack-targets
     ARCHIVE DESTINATION lib${LIB_SUFFIX}
@@ -114,18 +108,11 @@ set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${SCALAPACK_BINARY_DIR}/lib)
 
 # --------------------------------------------------
 # By default static library
-function (invertBoolean varName varValue)
-  if (${varValue})
-    set(${varName} false PARENT_SCOPE)
-  else ()
-    set(${varName} true PARENT_SCOPE)
-  endif ()
-endfunction ()
 option(BUILD_SHARED_LIBS "Build shared libraries" OFF )
-invertBoolean("BUILD_STATIC_LIBS" ${BUILD_SHARED_LIBS})
-if ((${BUILD_SHARED_LIBS} EQUAL ON) AND NOT CMAKE_POSITION_INDEPENDENT_CODE)
+set(BUILD_STATIC_LIBS $<NOT:BUILD_SHARED_LIBS>)
+if(BUILD_SHARED_LIBS)
   set(CMAKE_POSITION_INDEPENDENT_CODE ON)
-endif ()
+endif()
 
 # --------------------------------------------------
 # Check for any necessary platform specific compiler flags
@@ -166,13 +153,25 @@ IF(LAPACK_LIBRARIES)
   include(CheckFortranFunctionExists)
   message(STATUS "--> LAPACK supplied by user is ${LAPACK_LIBRARIES}.")
   set(CMAKE_REQUIRED_LIBRARIES ${LAPACK_LIBRARIES})
-  CHECK_FORTRAN_FUNCTION_EXISTS("dgesv" LAPACK_FOUND)
+  set(LAPACK_FOUND true)
+  if(BUILD_SINGLE)
+    check_fortran_function_exists("sgesv" LAPACK_s_FOUND)
+    if(NOT LAPACK_s_FOUND)
+      set(LAPACK_FOUND false)
+    endif()
+  endif()
+  if(BUILD_DOUBLE)
+    check_fortran_function_exists("dgesv" LAPACK_d_FOUND)
+    if(NOT LAPACK_d_FOUND)
+      set(LAPACK_FOUND false)
+    endif()
+  endif()
   unset( CMAKE_REQUIRED_LIBRARIES )
-  message(STATUS "--> LAPACK routine dgesv is found: ${LAPACK_FOUND}.")
+  message(STATUS "--> LAPACK routine gesv is found: ${LAPACK_FOUND}.")
 ENDIF()
 
 if(LAPACK_FOUND)
-      message(STATUS "--> LAPACK supplied by user is WORKING, will use ${LAPACK_LIBRARIES}.")
+  message(STATUS "--> LAPACK supplied by user is WORKING, will use ${LAPACK_LIBRARIES}.")
 else(LAPACK_FOUND)
    if(USE_OPTIMIZED_LAPACK_BLAS)
       message(STATUS "--> Searching for optimized LAPACK and BLAS libraries on your machine.")
@@ -258,27 +257,33 @@ append_subdir_files(src-C "SRC")
 
 if (NOT MSVC)
    add_library(scalapack ${blacs} ${tools} ${tools-C} ${extra_lapack} ${pblas} ${pblas-F} ${ptzblas} ${ptools} ${pbblas} ${redist} ${src} ${src-C})
-   set_target_properties(scalapack PROPERTIES
-    VERSION ${SCALAPACK_VERSION}
-    SOVERSION ${SCALAPACK_VERSION_MAJOR}.${SCALAPACK_VERSION_MINOR})
-   target_link_libraries( scalapack ${LAPACK_LIBRARIES} ${BLAS_LIBRARIES} MPI::MPI_C)
-   scalapack_install_library(scalapack)
 else () # Need to separate Fortran and C Code
    OPTION(BUILD_SHARED_LIBS "Build shared libraries" ON )
    add_library(scalapack ${blacs} ${tools-C} ${pblas} ${ptools} ${redist} ${src-C})
-   set_target_properties(scalapack PROPERTIES
-    VERSION ${SCALAPACK_VERSION}
-    SOVERSION ${SCALAPACK_VERSION_MAJOR}.${SCALAPACK_VERSION_MINOR})
-   target_link_libraries( scalapack ${LAPACK_LIBRARIES} ${BLAS_LIBRARIES} MPI::MPI_C)
    add_library(scalapack-F ${pblas-F} ${pbblas} ${ptzblas} ${tools} ${src} ${extra_lapack} )
    set_target_properties(scalapack-F PROPERTIES
     VERSION ${SCALAPACK_VERSION}
     SOVERSION ${SCALAPACK_VERSION_MAJOR}.${SCALAPACK_VERSION_MINOR})
-   target_link_libraries( scalapack-F ${LAPACK_LIBRARIES} ${BLAS_LIBRARIES} MPI::MPI_Fortran)
-   scalapack_install_library(scalapack)
+   target_link_libraries( scalapack-F PRIVATE ${LAPACK_LIBRARIES} ${BLAS_LIBRARIES} MPI::MPI_Fortran)
    scalapack_install_library(scalapack-F)
 endif ()
 
+include(CheckCCompilerFlag)
+# C99+ default compilers such as Clang error without this
+# test the non-no form, otherwise always succeeds
+check_c_compiler_flag(-Wimplicit-function-declaration HAS_IMPLICIT_FUNC_FLAG)
+if(HAS_IMPLICIT_FUNC_FLAG)
+  target_compile_options(scalapack PRIVATE $<$<COMPILE_LANGUAGE:C>:-Wno-implicit-function-declaration>)
+endif()
+
+target_link_libraries(scalapack PRIVATE ${LAPACK_LIBRARIES} ${BLAS_LIBRARIES} MPI::MPI_C)
+
+set_target_properties(scalapack PROPERTIES
+  VERSION ${SCALAPACK_VERSION}
+  SOVERSION ${SCALAPACK_VERSION_MAJOR}.${SCALAPACK_VERSION_MINOR})
+
+scalapack_install_library(scalapack)
+
 if(TARGET lapack)
    add_dependencies(scalapack lapack)
 endif()

PBLAS/TESTING/CMakeLists.txt

@@ -1,3 +1,7 @@
+if (CMAKE_Fortran_COMPILER_ID STREQUAL "GNU" AND CMAKE_Fortran_COMPILER_VERSION VERSION_GREATER_EQUAL 10)
+  add_compile_options("$<$<COMPILE_LANGUAGE:Fortran>:-fallow-argument-mismatch;-std=legacy>")
+endif()
+
 file(COPY ../SRC/PTOOLS/PB_Cwarn.c DESTINATION ${CMAKE_CURRENT_SOURCE_DIR})
 file(COPY ../SRC/PTOOLS/PB_Cabort.c DESTINATION ${CMAKE_CURRENT_SOURCE_DIR})
 
@@ -44,7 +48,3 @@ if(BUILD_SINGLE AND BUILD_COMPLEX16)
   _pblas_test(zpb2tst "pzblas2tst.f;${zpbtcom}")
   _pblas_test(zpb3tst "pzblas3tst.f;${zpbtcom}")
 endif()
-
-if (CMAKE_Fortran_COMPILER_ID STREQUAL "GNU" AND CMAKE_Fortran_COMPILER_VERSION VERSION_GREATER_EQUAL 10)
-  add_compile_options($<$<COMPILE_LANGUAGE:Fortran>:-std=legacy>)  # local to this directory
-endif()

PBLAS/TIMING/CMakeLists.txt

@@ -1,3 +1,7 @@
+if (CMAKE_Fortran_COMPILER_ID STREQUAL "GNU" AND CMAKE_Fortran_COMPILER_VERSION VERSION_GREATER_EQUAL 10)
+  add_compile_options("$<$<COMPILE_LANGUAGE:Fortran>:-fallow-argument-mismatch;-std=legacy>")
+endif()
+
 file(COPY ../SRC/PTOOLS/PB_Cwarn.c DESTINATION ${CMAKE_CURRENT_SOURCE_DIR})
 file(COPY ../SRC/PTOOLS/PB_Cabort.c DESTINATION ${CMAKE_CURRENT_SOURCE_DIR})
 
@@ -44,7 +48,3 @@ if(BUILD_SINGLE AND BUILD_COMPLEX16)
   _pblas_test(zpb2tim "pzblas2tim.f;${zpbtcom}")
   _pblas_test(zpb3tim "pzblas3tim.f;${zpbtcom}")
 endif()
-
-if (CMAKE_Fortran_COMPILER_ID STREQUAL "GNU" AND CMAKE_Fortran_COMPILER_VERSION VERSION_GREATER_EQUAL 10)
-  add_compile_options($<$<COMPILE_LANGUAGE:Fortran>:-std=legacy>)  # local to this directory
-endif()

TESTING/EIG/CMakeLists.txt

@@ -1,3 +1,8 @@
+if (CMAKE_Fortran_COMPILER_ID STREQUAL "GNU" AND CMAKE_Fortran_COMPILER_VERSION VERSION_GREATER_EQUAL 10)
+  add_compile_options("$<$<COMPILE_LANGUAGE:Fortran>:-fallow-argument-mismatch;-std=legacy>")
+endif()
+
+
 set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/..)
 
 set (smatgen psmatgen.f pmatgeninc.f)
@@ -57,8 +62,3 @@ if(BUILD_SINGLE AND BUILD_COMPLEX16)
   _eig_test(xzevc "pzevcdriver.f;pzevcinfo.f;pzget22.f;${zmatgen}" 2)
   _eig_test(xzheevr "pzlasizesepr.f;pzlasizeheevr.f;pzseprdriver.f;pzseprreq.f;pzseprsubtst.f;pzsepchk.f;pzsepqtq.f;pzlatms.f;pzseprtst.f;pdsepinfo.f;pzlagsy.f;pzlasizesep.f;${zmatgen}" 4)
 endif()
-
-
-if (CMAKE_Fortran_COMPILER_ID STREQUAL "GNU" AND CMAKE_Fortran_COMPILER_VERSION VERSION_GREATER_EQUAL 10)
-  add_compile_options($<$<COMPILE_LANGUAGE:Fortran>:-std=legacy>)  # local to this directory
-endif()

TESTING/LIN/CMakeLists.txt

@@ -1,3 +1,8 @@
+if (CMAKE_Fortran_COMPILER_ID STREQUAL "GNU" AND CMAKE_Fortran_COMPILER_VERSION VERSION_GREATER_EQUAL 10)
+  add_compile_options("$<$<COMPILE_LANGUAGE:Fortran>:-fallow-argument-mismatch;-std=legacy>")
+endif()
+
+
 set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/..)
 
 set (smatgen psmatgen.f pmatgeninc.f)
@@ -70,8 +75,3 @@ if(BUILD_SINGLE AND BUILD_COMPLEX16)
   _lin_test(xzqr "pzqrdriver.f;pzqrinfo.f;pzgeqrrv.f;pzgeqlrv.f;pzgelqrv.f;pzgerqrv.f;pztzrzrv.f;pzlafchk.f;${zmatgen}")
   _lin_test(xzls "pzlsdriver.f;pzlsinfo.f;pzqrt13.f;pzqrt14.f;pzqrt16.f;pzqrt17.f;${zmatgen}")
 endif()
-
-
-if (CMAKE_Fortran_COMPILER_ID STREQUAL "GNU" AND CMAKE_Fortran_COMPILER_VERSION VERSION_GREATER_EQUAL 10)
-  add_compile_options($<$<COMPILE_LANGUAGE:Fortran>:-std=legacy>)  # local to this directory
-endif()