check non-boolean value

Author: AvitalFineRedis

rejson/client.py

@@ -57,7 +57,7 @@ def __init__(self, encoder=None, decoder=None, *args, **kwargs):
                 'JSON.SET': lambda r: r and nativestr(r) == 'OK',
                 'JSON.NUMINCRBY': self._decode,
                 'JSON.NUMMULTBY': self._decode,
-                'JSON.TOGGLE': bool,
+                'JSON.TOGGLE': lambda b: b == 'true',
                 'JSON.STRAPPEND': long,
                 'JSON.STRLEN': long,
                 'JSON.ARRAPPEND': long,
@@ -71,7 +71,7 @@ def __init__(self, encoder=None, decoder=None, *args, **kwargs):
         }
         for k, v in six.iteritems(MODULE_CALLBACKS):
             self.set_response_callback(k, v)
-                                    
+
     def setEncoder(self, encoder):
         """
         Sets the client's encoder

tests/test_rejson.py

@@ -1,3 +1,5 @@
+import pytest
+import redis
 import six
 import json
 import unittest
@@ -36,7 +38,7 @@ def testJSONSetGetDelNonAsciiShouldSucceed(self):
     def testJSONSetExistentialModifiersShouldSucceed(self):
         "Test JSONSet's NX/XX flags"
 
-        obj = { 'foo': 'bar' }
+        obj = {'foo': 'bar'}
         self.assertTrue(rj.jsonset('obj', Path.rootPath(), obj))
 
         # Test that flags prevent updates when conditions are unmet
@@ -93,8 +95,12 @@ def testToggleShouldSucceed(self):
         "Test JSONToggle"
 
         rj.jsonset('bool', Path.rootPath(), False)
-        self.assertTrue(rj.jsontoggle('bool', Path.rootPath()))        
+        self.assertTrue(rj.jsontoggle('bool', Path.rootPath()))
         self.assertFalse(rj.jsontoggle('bool', Path.rootPath()))
+        # check non-boolean value
+        rj.jsonset('num', Path.rootPath(), 1)
+        with pytest.raises(redis.exceptions.ResponseError):
+            rj.jsontoggle('num', Path.rootPath())
 
     def testStrAppendShouldSucceed(self):
         "Test JSONStrAppend"