Skip to content

Commit 4c9fe1e

Browse files
committed
Script improvements
1 parent a7f7507 commit 4c9fe1e

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

bulk_insert.py

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,8 @@ class NodeFile(EntityFile):
104104
def __init__(self, infile):
105105
super(NodeFile, self).__init__(infile)
106106
self.process_header()
107+
self.process_entities()
108+
self.infile.close()
107109

108110
def process_header(self):
109111
# Header format:
@@ -135,13 +137,14 @@ def process_entities(self):
135137
NODE_COUNT += 1
136138
self.entity_count += 1
137139
self.entities.append(self.pack_props(row))
138-
self.infile.close()
139140

140141

141142
class RelationFile(EntityFile):
142143
def __init__(self, infile):
143144
super(RelationFile, self).__init__(infile)
144145
self.process_header()
146+
self.process_entities()
147+
self.infile.close()
145148

146149
def process_header(self):
147150
# Header format:
@@ -175,22 +178,17 @@ def process_entities(self):
175178
self.entity_count += 1
176179
RELATION_COUNT += 1
177180
self.entities.append(struct.pack(fmt, src, dest) + self.pack_props(row))
178-
self.infile.close()
179181

180182
def process_node_csvs(csvs):
181183
nodefiles = []
182184
for in_csv in csvs:
183-
nodefile = NodeFile(in_csv)
184-
nodefile.process_entities()
185-
nodefiles.append(nodefile)
185+
nodefiles.append(NodeFile(in_csv))
186186
return nodefiles
187187

188188
def process_relation_csvs(csvs):
189189
relfiles = []
190190
for in_csv in csvs:
191-
relfile = RelationFile(in_csv)
192-
relfile.process_entities()
193-
relfiles.append(relfile)
191+
relfiles.append(RelationFile(in_csv))
194192
return relfiles
195193

196194

@@ -203,7 +201,7 @@ def help():
203201
# Redis server connection settings
204202
@click.option('--host', '-h', default='127.0.0.1', help='Redis server host')
205203
@click.option('--port', '-p', default=6379, help='Redis server port')
206-
@click.option('--password', '-P', default=None, help='Redis server password')
204+
@click.option('--password', '-a', default=None, help='Redis server password')
207205
# CSV file paths
208206
@click.option('--nodes', '-n', required=True, multiple=True, help='path to node csv file')
209207
@click.option('--relations', '-r', multiple=True, help='path to relation csv file')

0 commit comments

Comments
 (0)