fix(operators): Debug lettable operators and remove dead code

Author: feloy

src/app/operators/components/operator/operator.component.ts

@@ -32,18 +32,20 @@ export class OperatorComponent implements OnInit {
   ) {}
 
   ngOnInit() {
-    this._activatedRoute.params.pluck('operator').subscribe((name: string) => {
-      this.operator =
-        this.operators.filter(
-          (operator: OperatorDoc) => operator.name === name
-        )[0] || this.notfound();
-      this._seo.setHeaders(
-        [this.operator.name, this.operator.operatorType],
-        this.operator.shortDescription
-          ? this.operator.shortDescription.description
-          : ''
-      );
-    });
+    this._activatedRoute.params
+      .pipe(pluck('operator'))
+      .subscribe((name: string) => {
+        this.operator =
+          this.operators.filter(
+            (operator: OperatorDoc) => operator.name === name
+          )[0] || this.notfound();
+        this._seo.setHeaders(
+          [this.operator.name, this.operator.operatorType],
+          this.operator.shortDescription
+            ? this.operator.shortDescription.description
+            : ''
+        );
+      });
   }
 
   get operatorName() {

src/app/operators/operators.component.ts

@@ -3,7 +3,6 @@ import {
   Inject,
   InjectionToken,
   OnInit,
-  AfterViewInit,
   ChangeDetectionStrategy
 } from '@angular/core';
 import {
@@ -55,14 +54,12 @@ interface OperatorDocMap {
     ])
   ]
 })
-export class OperatorsComponent implements OnInit, AfterViewInit {
+export class OperatorsComponent implements OnInit {
   public groupedOperators: OperatorDocMap;
   public categories: string[];
 
   constructor(
     private _breakpointObserver: BreakpointObserver,
-    private _router: Router,
-    private _activatedRoute: ActivatedRoute,
     @Inject(OPERATORS_TOKEN) public operators: OperatorDoc[],
     private _seo: SeoService
   ) {}
@@ -73,24 +70,6 @@ export class OperatorsComponent implements OnInit, AfterViewInit {
     this._seo.setHeaders(['Operators'], this._seo.operatorsDescription);
   }
 
-  ngAfterViewInit() {
-    // scroll initial param when applicable
-    const name = this._activatedRoute.snapshot.fragment;
-
-    if (name) {
-      // slight delay for scroll to be accurate
-      setTimeout(() => this.scrollToOperator(name), 100);
-    }
-  }
-
-  scrollToOperator(name: string) {
-    const element = document.getElementById(name);
-
-    if (element) {
-      element.scrollIntoView();
-    }
-  }
-
   get extraSmallScreen() {
     return this._breakpointObserver.isMatched('(max-width: 601px)');
   }

src/app/operators/specs/operators.spec.ts

@@ -64,13 +64,6 @@ describe('Operators', () => {
       expect(component.groupedOperators['utility'].length).toBe(2);
     });
 
-    it('should scroll to initial operator when fragment exists', () => {
-      spyOn(component, 'scrollToOperator').and.stub();
-      component.ngOnInit();
-
-      expect(component.scrollToOperator).toHaveBeenCalledWith('merge');
-    });
-
     it('should have a sidenav mode of over when on a small screen', () => {
       spyOn(breakpointService, 'isMatched').and.returnValue(true);