Skip to content
This repository was archived by the owner on Oct 1, 2018. It is now read-only.

Commit 883ef9c

Browse files
Merge pull request #203 from knittingcodemonkey/iFrameTitlesAndLandmarks
feat(Accessibility): Add titles, values and landmarks
2 parents 8be26cf + ebf0259 commit 883ef9c

File tree

3 files changed

+23
-20
lines changed

3 files changed

+23
-20
lines changed

src/app/app.component.html

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,18 @@
22
<header>
33
<app-toolbar (navToggle)="sidenav.toggle()"></app-toolbar>
44
</header>
5-
<mat-sidenav-container>
6-
<mat-sidenav #sidenav role="navigation">
7-
<mat-nav-list (click)="sidenav.toggle()">
8-
<a *ngFor="let menu of menus" mat-list-item routerLinkActive="active" [routerLinkActiveOptions]="menu.options" [routerLink]="menu.link">
5+
<main>
6+
<mat-sidenav-container>
7+
<mat-sidenav #sidenav role="navigation">
8+
<mat-nav-list (click)="sidenav.toggle()">
9+
<a *ngFor="let menu of menus" mat-list-item routerLinkActive="active" [routerLinkActiveOptions]="menu.options" [routerLink]="menu.link">
910
{{menu.title}}
1011
</a>
11-
</mat-nav-list>
12-
</mat-sidenav>
13-
<router-outlet></router-outlet>
14-
</mat-sidenav-container>
15-
</div>
12+
</mat-nav-list>
13+
</mat-sidenav>
14+
<article>
15+
<router-outlet></router-outlet>
16+
</article>
17+
</mat-sidenav-container>
18+
</main>
19+
</div>

src/app/operators/_operator-theme.scss

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22

33
$operator-border: #f3f3f3;
44
$operator-active: #62757f;
5-
$link-color: #2196F3;
5+
$link-color: #2196f3;
66

77
@mixin operator-theme($theme) {
88
$primary: mat-color(map-get($theme, primary));
99
$accent: mat-color(map-get($theme, accent));
10-
$operator-active-background: rgba($operator-active, .7);
10+
$operator-active-background: rgba($operator-active, 0.7);
1111

1212
rx-marbles > div {
1313
text-align: center;
@@ -24,6 +24,10 @@ $link-color: #2196F3;
2424
color: $link-color;
2525
}
2626

27+
app-operator a:hover {
28+
text-decoration: underline;
29+
}
30+
2731
.operator-list {
2832
a {
2933
border-bottom: 1px solid $operator-border;
Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,14 @@
11
<h2> Examples </h2>
2-
<div class="code-example"
3-
*ngFor="let example of operatorExamples"
4-
appHighlightJs>
2+
<div class="code-example" *ngFor="let example of operatorExamples" appHighlightJs>
53
<div class="code-block mat-elevation-z2">
64
<div class="example-header">
7-
<div class="header-title"
8-
[innerHTML]="example.name"></div>
9-
<button mat-icon-button
10-
(click)="copyToClipboard.emit(example.code)"
11-
matTooltip="Copy">
5+
<div class="header-title" [innerHTML]="example.name"></div>
6+
<button mat-icon-button (click)="copyToClipboard.emit(example.code)" value="Copy" aria-label="Copy" matTooltip="Copy">
127
<mat-icon>content_copy</mat-icon>
138
</button>
149
</div>
1510
<div class="bin-wrapper">
16-
<iframe [src]="example.externalLink.url | safeUrl"></iframe>
11+
<iframe [src]="example.externalLink.url | safeUrl" [title]="example.name"></iframe>
1712
</div>
1813
</div>
1914
</div>

0 commit comments

Comments
 (0)