Merge pull request #30 from kwonoj/chore-danger

chore(danger): setup danger bot

Author: kwonoj

.travis.yml

@@ -1,19 +1,29 @@
 sudo: required
+
 dist: trusty
+
 addons:
   apt:
     sources:
       - google-chrome
     packages:
       - google-chrome-stable
+
 language: node_js
+
 node_js:
- - "7"
+  - "7"
+
 before_script:
   - export DISPLAY=:99.0
   - sh -e /etc/init.d/xvfb start
+
+before_install:
+  - npm install -g npm@5
+
 script:
- - ng lint
- - ng test --single-run
- - ng build -prod
- - ng e2e
+  - if [ -n "DANGER_GITHUB_API_TOKEN" ]; then echo {} > ./.babelrc && npx danger; fi
+  - ng lint
+  - ng test --single-run
+  - ng build -prod
+  - ng e2e

dangerfile.js

@@ -0,0 +1,43 @@
+const fs = require('fs');
+const path = require('path');
+const validateMessage = require('validate-commit-msg');
+
+let errorCount = 0;
+
+// Warn when PR size is large
+const bigPRThreshold = 600;
+if (danger.github.pr.additions + danger.github.pr.deletions > bigPRThreshold) {
+  warn(':exclamation: Big PR (' + ++errorCount + ')');
+  markdown('> (' + errorCount + ') : Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.');
+}
+
+// Check test exclusion (.only) is included
+const modifiedSpecFiles = danger.git.modified_files.filter(function (filePath) {
+  return filePath.match(/.spec.(js|jsx|ts|tsx)$/gi);
+});
+
+const testFilesIncludeExclusion = modifiedSpecFiles.reduce(function (acc, value) {
+  const content = fs.readFileSync(value).toString();
+  const invalid =
+    _.includes(content, 'it.only') || _.includes(content, 'describe.only')
+  _.includes(content, 'fit(') || _.includes(content, 'fdescribe(');
+  if (invalid) {
+    acc.push(path.basename(value));
+  }
+  return acc;
+}, []);
+
+if (testFilesIncludeExclusion.length > 0) {
+  fail('an \`only\` was left in tests (' + testFilesIncludeExclusion + ')');
+}
+
+//validate commit message in PR if it conforms conventional change log, notify if it doesn't.
+const messageConventionValid = danger.git.commits.reduce(function (acc, value) {
+  const valid = validateMessage(value.message);
+  return valid && acc;
+}, true);
+
+if (!messageConventionValid) {
+  warn('commit message does not follows conventional change log (' + ++errorCount + ')');
+  markdown('> (' + errorCount + ') : RxJS uses conventional change log to generate changelog automatically. It seems some of commit messages are not following those, please check [contributing guideline](https://github.com/ReactiveX/rxjs/blob/master/CONTRIBUTING.md#commit-message-format) and update commit messages.');
+}

package.json

@@ -37,9 +37,11 @@
     "@angular/service-worker": "1.0.0-beta.16",
     "@types/jasmine": "2.5.53",
     "@types/jasminewd2": "2.0.2",
+    "@types/lodash": "4.14.77",
     "@types/node": "6.0.60",
     "angular2-template-loader": "0.6.2",
     "codelyzer": "3.1.1",
+    "danger": "1.2.0",
     "electron": "1.6.11",
     "jasmine-core": "2.6.2",
     "jasmine-spec-reporter": "4.1.0",
@@ -49,10 +51,12 @@
     "karma-coverage-istanbul-reporter": "1.2.1",
     "karma-jasmine": "1.1.0",
     "karma-jasmine-html-reporter": "0.2.2",
+    "lodash": "4.17.4",
     "protractor": "5.1.2",
     "ts-node": "3.2.0",
     "tslint": "5.3.2",
     "typescript": "2.3.3",
+    "validate-commit-msg": "2.14.0",
     "wallaby-webpack": "*"
   }
 }