simplify class sink when emitting strings

Author: dariomannu

src/parser/sink-map.ts

@@ -4,7 +4,7 @@ import type { Sink } from "../types/sink";
 import { AppendHTMLSink } from "../sinks/append-html-sink";
 import { BlurSink } from "../sinks/blur-sink";
 import { CheckedSink } from "../sinks/checked-sink";
-import { ClassName, ClassObjectSink, ToggleClass } from "../sinks/class-sink";
+import { ClassObjectSink } from "../sinks/class-sink";
 import { ClosedSink } from "../sinks/closed-sink";
 import { DatasetSink, DatasetObjectSink } from "../sinks/dataset-sink";
 import { DisabledSink } from "../sinks/disabled-sink";

src/sinks/class-sink.test.ts

@@ -3,64 +3,89 @@ import { ClassObjectSink, ToggleClassSink } from './class-sink';
 
 describe('Class Sink', () => {
 
-    describe('Given a class object', () => {
-
-        it('sets classes for truthy attributes on sink', () => {
-            const el = MockElement();
-            const sink = ClassObjectSink(<HTMLElement>el);
-
-            sink({
-                class1: true,
-                class2: 1,
-                class3: 'yes!',
-            });
-            expect(el.className).toContain('class1');
-            expect(el.className).toContain('class2');
-            expect(el.className).toContain('class3');
-        });
-
-        it('clears classes for falsy attributes on sink', () => {
-            const el = MockElement({ className: 'class1 class2 class3' });
-            const sink = ClassObjectSink(<HTMLElement>el);
-            expect(el.className).toContain('class1');
-            expect(el.className).toContain('class2');
-            expect(el.className).toContain('class3');
-
-            sink({
-                class1: false,
-                class2: 0,
-                class3: '',
-            });
-            expect(el.className).not.toContain('class1');
-            expect(el.className).not.toContain('class2');
-            expect(el.className).not.toContain('class3');
-        });
-
-    });
+	describe('Given a class string', () => {
+
+		it('sets className on sink', () => {
+			const el = MockElement({ className: 'class1 class2 class3' });
+			const sink = ClassObjectSink(<HTMLElement>el);
+
+			sink('class1');
+			expect(el.className).toEqual('class1');
+		});
+
+		it('clears classes for empty strings on sink', () => {
+			const el = MockElement({ className: 'class1 class2 class3' });
+			const sink = ClassObjectSink(<HTMLElement>el);
+
+			sink({
+				class1: false,
+				class2: 0,
+				class3: '',
+			});
+			expect(el.className).toEqual('');
+		});
+
+	});
+
+
+	describe('Given a class object', () => {
+
+		it('sets classes for truthy attributes on sink', () => {
+			const el = MockElement();
+			const sink = ClassObjectSink(<HTMLElement>el);
+
+			sink({
+				class1: true,
+				class2: 1,
+				class3: 'yes!',
+			});
+			expect(el.className).toContain('class1');
+			expect(el.className).toContain('class2');
+			expect(el.className).toContain('class3');
+		});
+
+		it('clears classes for falsy attributes on sink', () => {
+			const el = MockElement({ className: 'class1 class2 class3' });
+			const sink = ClassObjectSink(<HTMLElement>el);
+			expect(el.className).toContain('class1');
+			expect(el.className).toContain('class2');
+			expect(el.className).toContain('class3');
+
+			sink({
+				class1: false,
+				class2: 0,
+				class3: '',
+			});
+			expect(el.className).not.toContain('class1');
+			expect(el.className).not.toContain('class2');
+			expect(el.className).not.toContain('class3');
+		});
+
+	});
 
 });
 
 describe('Class Toggle Sink', () => {
 
-    describe('Given a class object', () => {
+	describe('Given a class object', () => {
 
-        it('sets classes for truthy value on sink', () => {
-            const el = MockElement();
-            const sink = ToggleClassSink('class1')(<HTMLElement>el);
+		it('sets classes for truthy value on sink', () => {
+			const el = MockElement();
+			const sink = ToggleClassSink('class1')(<HTMLElement>el);
 
-            sink(true);
-            expect(el.className).toContain('class1');
-        });
+			sink(true);
+			expect(el.className).toContain('class1');
+		});
 
-        it('clears classes for falsy values on sink', () => {
-            const el = MockElement({ className: 'class1' });
-            const sink = ToggleClassSink('class1')(<HTMLElement>el);
+		it('clears classes for falsy values on sink', () => {
+			const el = MockElement({ className: 'class1' });
+			const sink = ToggleClassSink('class1')(<HTMLElement>el);
 
-            sink(false);
-            expect(el.className).not.toContain('class1');
-        });
+			sink(false);
+			expect(el.className).not.toContain('class1');
+		});
 
-    });
+	});
 
 });
 

src/sinks/class-sink.ts

@@ -31,9 +31,7 @@ export const ClassObjectSink: Sink<Element> = (node: Element) => {
 
 	return (name: ClassName | ClassRecord | ((ClassName | ClassRecord)[])) => {
 		typeof name == 'string'
-			? name.includes(' ')
-				? set(name)
-				: add(name)
+			? set(name)
 			// FIXME: is it safe to assume it's an object, at this point?
 			: (<(ClassName | ClassRecord)[]>[]).concat(name).forEach(obj => Object.entries(obj)
 					// TODO: support 3-state with toggle