ViewStore producer API improvements

- `StoreProducer<State>` renamed to `Produced<Value>`
- `viewStore.producer: StoreProducer<State>` renamed to `viewStore.produced: Produced<State>`

Author: maximkrouk

Sources/ComposableArchitecture/Debugging/ReducerInstrumentation.swift

@@ -1,4 +1,3 @@
-import ReactiveSwift
 import os.signpost
 
 extension Reducer {

Sources/ComposableArchitecture/Store.swift

@@ -195,20 +195,22 @@ public final class Store<State, Action> {
 
 /// A producer of store state.
 @dynamicMemberLookup
-public struct StoreProducer<State>: SignalProducerConvertible {
-  public let producer: Effect<State, Never>
+public struct Produced<Value>: SignalProducerConvertible {
+  public let producer: Effect<Value, Never>
 
-  init(_ upstream: Effect<State, Never>) {
+  init(by upstream: Effect<Value, Never>) {
     self.producer = upstream
   }
 
   /// Returns the resulting producer of a given key path.
-  public subscript<LocalState>(
-    dynamicMember keyPath: KeyPath<State, LocalState>
-  ) -> Effect<LocalState, Never>
-  where LocalState: Equatable {
+  public subscript<LocalValue>(
+    dynamicMember keyPath: KeyPath<Value, LocalValue>
+  ) -> Effect<LocalValue, Never> where LocalValue: Equatable {
     self.producer.map(keyPath).skipRepeats()
   }
-    
-  public var state: Effect<State, Never> { producer }
 }
+
+@available(*, deprecated, message:"""
+Consider using `Produced<State>` instead, this typealias is added for backward compatibility and will be removed in the next major release.
+""")
+public typealias StoreProducer<State> = Produced<State>

Sources/ComposableArchitecture/ViewStore.swift

@@ -44,7 +44,12 @@ import SwiftUI
 @dynamicMemberLookup
 public final class ViewStore<State, Action>: ObservableObject {
   /// A producer of state.
-  public let producer: StoreProducer<State>
+  public let produced: Produced<State>
+    
+  @available(*, deprecated, message: """
+  Consider using `.produced` instead, this variable is added for backward compatibility and will be removed in the next major release.
+  """)
+  var producer: Produced<State> { produced }
 
   /// Initializes a view store from a store.
   ///
@@ -57,7 +62,7 @@ public final class ViewStore<State, Action>: ObservableObject {
     removeDuplicates isDuplicate: @escaping (State, State) -> Bool
   ) {
     let producer = store.$state.producer.skipRepeats(isDuplicate)
-    self.producer = StoreProducer(producer)
+    self.produced = Produced(by: producer)
     self.state = store.state
     self._send = store.send
     producer.startWithValues { [weak self] in

Tests/ComposableArchitectureTests/MemoryManagementTests.swift

@@ -14,7 +14,7 @@ final class MemoryManagementTests: XCTestCase {
     let viewStore = ViewStore(store)
 
     var count = 0
-    viewStore.producer.producer.startWithValues { count = $0 }
+    viewStore.produced.producer.startWithValues { count = $0 }
 
     XCTAssertEqual(count, 0)
     viewStore.send(())
@@ -29,7 +29,7 @@ final class MemoryManagementTests: XCTestCase {
     let viewStore = ViewStore(Store(initialState: 0, reducer: counterReducer, environment: ()))
 
     var count = 0
-    viewStore.producer.producer.startWithValues { count = $0 }
+    viewStore.produced.producer.startWithValues { count = $0 }
 
     XCTAssertEqual(count, 0)
     viewStore.send(())

Tests/ComposableArchitectureTests/StoreTests.swift

@@ -284,7 +284,7 @@ final class StoreTests: XCTestCase {
       let vs = ViewStore(childStore)
 
       vs
-        .producer.producer
+        .produced.producer
         .startWithValues { _ in }
 
       vs.send(false)