api34

hannesa2 · hannesa2 · commit 49dcb5707769 · 2024-10-13T18:52:53.000+02:00
diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml
@@ -21,6 +21,12 @@ jobs:
       - name: assemble ViroCore
         run: |
           ./gradlew :viroreact:assembleDebug
+          ./gradlew :code-samples:ARPlacingObjects:assembleDebug
+          ./gradlew :code-samples:ARRetail:assembleDebug
+          ./gradlew :code-samples:ARTesla:assembleDebug
+          ./gradlew :code-samples:ARHelloWorldAndroid:assembleDebug
+          ./gradlew :code-samples:ARBlackPanther:assembleDebug
+          ./gradlew :mainSample:assembleDebug
         working-directory: ./android
       - name: Upload result ViroCore
         uses: actions/upload-artifact@v4.4.0
diff --git a/android/code-samples/ARBlackPanther/build.gradle b/android/code-samples/ARBlackPanther/build.gradle
@@ -1,12 +1,12 @@
 apply plugin: 'com.android.library'
 
 android {
-    compileSdkVersion 33
+    compileSdkVersion 34
     namespace "com.example.virosample.blackPanther"
 
     defaultConfig {
         minSdkVersion 24
-        targetSdkVersion 33
+        targetSdkVersion 34
         testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
         ndkVersion = "25.2.9519653"
         ndk {
diff --git a/android/code-samples/ARHelloWorldAndroid/build.gradle b/android/code-samples/ARHelloWorldAndroid/build.gradle
@@ -1,12 +1,12 @@
 apply plugin: 'com.android.library'
 
 android {
-    compileSdkVersion 33
+    compileSdkVersion 34
     namespace "com.example.virosample.hello"
 
     defaultConfig {
         minSdkVersion 24
-        targetSdkVersion 33
+        targetSdkVersion 34
         testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
         ndkVersion = "25.2.9519653"
         ndk {
diff --git a/android/code-samples/ARPlacingObjects/build.gradle b/android/code-samples/ARPlacingObjects/build.gradle
@@ -2,12 +2,12 @@ apply plugin: 'com.android.library'
 apply plugin: 'kotlin-android'
 
 android {
-    compileSdkVersion 33
+    compileSdkVersion 34
     namespace "com.example.virosample.placingObjects"
 
     defaultConfig {
         minSdkVersion 24
-        targetSdkVersion 33
+        targetSdkVersion 34
         testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
         ndkVersion = "25.2.9519653"
         ndk {
diff --git a/android/code-samples/ARRetail/build.gradle b/android/code-samples/ARRetail/build.gradle
@@ -1,12 +1,12 @@
 apply plugin: 'com.android.library'
 
 android {
-    compileSdkVersion 33
+    compileSdkVersion 34
     namespace "com.example.virosample.retail"
 
     defaultConfig {
         minSdkVersion 24
-        targetSdkVersion 33
+        targetSdkVersion 34
         testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
         ndkVersion = "25.2.9519653"
         ndk {
diff --git a/android/code-samples/ARTesla/build.gradle b/android/code-samples/ARTesla/build.gradle
@@ -1,12 +1,12 @@
 apply plugin: 'com.android.library'
 
 android {
-    compileSdkVersion 33
+    compileSdkVersion 34
     namespace "com.example.virosample.tesla"
 
     defaultConfig {
         minSdkVersion 24
-        targetSdkVersion 33
+        targetSdkVersion 34
         testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
         ndkVersion = "25.2.9519653"
         ndk {
diff --git a/android/mainSample/build.gradle b/android/mainSample/build.gradle
@@ -2,7 +2,7 @@ apply plugin: 'com.android.application'
 apply plugin: 'kotlin-android'
 
 android {
-    compileSdkVersion 33
+    compileSdkVersion 34
     namespace "com.example.virosample"
     buildFeatures {
         buildConfig = true
@@ -11,7 +11,7 @@ android {
     defaultConfig {
         applicationId "com.example.virosample"
         minSdkVersion 24
-        targetSdkVersion 33
+        targetSdkVersion 34
 
         // versionCode getGitCommitCount()
         // versionName getTag()
diff --git a/android/memoryleaktest/build.gradle b/android/memoryleaktest/build.gradle
@@ -8,11 +8,11 @@ android {
         buildConfig = true
     }
 
-    compileSdkVersion 33
+    compileSdkVersion 34
     defaultConfig {
         applicationId "com.example.memoryleaktest"
         minSdkVersion 24
-        targetSdkVersion 33
+        targetSdkVersion 34
         versionCode 1
         versionName "1.0"
 
diff --git a/android/nativetest/build.gradle b/android/nativetest/build.gradle
@@ -6,12 +6,12 @@ android {
     buildFeatures {
         buildConfig = true
     }
-    compileSdkVersion 33
+    compileSdkVersion 34
 
     defaultConfig {
         applicationId "com.viro.nativetest"
         minSdkVersion 24
-        targetSdkVersion 33
+        targetSdkVersion 34
         versionCode 1
         versionName "1.0"
         missingDimensionStrategy 'product', 'viro_core'
diff --git a/android/releasetest/build.gradle b/android/releasetest/build.gradle
@@ -4,15 +4,15 @@ apply plugin: 'kotlin-android'
 android {
     flavorDimensions "target_platform"
     namespace "com.viromedia.releasetest"
-    compileSdkVersion 33
+    compileSdkVersion 34
     buildFeatures {
         buildConfig = true
     }
 
     defaultConfig {
         applicationId "com.viromedia.releasetest"
         minSdkVersion 24
-        targetSdkVersion 33
+        targetSdkVersion 34
         versionCode 1
         versionName "1.0"
 
diff --git a/android/renderertest/build.gradle b/android/renderertest/build.gradle
@@ -6,12 +6,12 @@ android {
     buildFeatures {
         buildConfig = true
     }
-    compileSdkVersion 33
+    compileSdkVersion 34
 
     defaultConfig {
         applicationId "com.viromedia.renderertest"
         minSdkVersion 24
-        targetSdkVersion 33
+        targetSdkVersion 34
         versionCode 1
         versionName "1.0"
         missingDimensionStrategy 'product', 'viro_core'
diff --git a/android/sharedCode/build.gradle b/android/sharedCode/build.gradle
@@ -13,11 +13,11 @@ android {
     buildFeatures {
         buildConfig = true
     }
-    compileSdkVersion 33
+    compileSdkVersion 34
 
     defaultConfig {
         minSdkVersion 24
-        targetSdkVersion 33
+        targetSdkVersion 34
         ndkVersion = "25.2.9519653"
 
         ndk {
diff --git a/android/viroar/build.gradle b/android/viroar/build.gradle
@@ -2,7 +2,7 @@ apply plugin: 'com.android.library'
 apply plugin: 'maven-publish'
 
 android {
-    compileSdkVersion 33
+    compileSdkVersion 34
     namespace "com.viro.ar"
 
     compileOptions {
@@ -12,7 +12,7 @@ android {
 
     defaultConfig {
         minSdkVersion 24
-        targetSdkVersion 33
+        targetSdkVersion 34
         ndkVersion = "25.2.9519653"
 
         ndk {
diff --git a/android/virocore/build.gradle b/android/virocore/build.gradle
@@ -3,7 +3,7 @@ apply from: 'preprocessor.gradle'
 apply plugin: 'maven-publish'
 
 android {
-    compileSdkVersion 33
+    compileSdkVersion 34
     namespace "com.viro.virocore"
     buildFeatures {
         buildConfig = true
@@ -15,7 +15,7 @@ android {
     }
     defaultConfig {
         minSdkVersion 24
-        targetSdkVersion 33
+        targetSdkVersion 34
         ndkVersion = "25.2.9519653"
 
         ndk {
diff --git a/android/viroreact/build.gradle b/android/viroreact/build.gradle
@@ -2,7 +2,7 @@ apply plugin: 'com.android.library'
 apply plugin: 'maven-publish'
 
 android {
-    compileSdkVersion 33
+    compileSdkVersion 34
     namespace "com.viro.viroreact"
     buildFeatures {
         buildConfig = true
@@ -14,7 +14,7 @@ android {
 
     defaultConfig {
         minSdkVersion 24
-        targetSdkVersion 33
+        targetSdkVersion 34
         ndkVersion = "25.2.9519653"
 
         ndk {
