fix: release event listners (#534)

mjeffrie · web-flow · commit 7cc12039a164 · 2020-05-06T22:26:33.000-05:00
diff --git a/src/index.js b/src/index.js
@@ -169,7 +169,7 @@ class ReactTooltip extends React.Component {
     this.clearTimer();
 
     this.unbindListener();
-    this.removeScrollListener();
+    this.removeScrollListener(this.state.currentTarget);
     this.unbindWindowEvents();
   }
 
@@ -573,7 +573,7 @@ class ReactTooltip extends React.Component {
       this.removeListenerForTooltipExit();
 
       this.setState({ show: false }, () => {
-        this.removeScrollListener();
+        this.removeScrollListener(this.state.currentTarget);
         if (isVisible && afterHide) {
           afterHide(e);
         }
@@ -604,8 +604,9 @@ class ReactTooltip extends React.Component {
     window.addEventListener("scroll", this.hideTooltipOnScroll, isCaptureMode);
   }
 
-  removeScrollListener() {
-    window.removeEventListener("scroll", this.hideTooltipOnScroll);
+  removeScrollListener(currentTarget) {
+    const isCaptureMode = this.isCapture(currentTarget);
+    window.removeEventListener("scroll", this.hideTooltipOnScroll, isCaptureMode);
   }
 
   // Calculation the position

Original file line number	Diff line number	Diff line change
`@@ -169,7 +169,7 @@ class ReactTooltip extends React.Component {`
`169`	`169`	`this.clearTimer();`
`170`	`170`
`171`	`171`	`this.unbindListener();`
`172`		`- this.removeScrollListener();`
	`172`	`+ this.removeScrollListener(this.state.currentTarget);`
`173`	`173`	`this.unbindWindowEvents();`
`174`	`174`	`}`
`175`	`175`
`@@ -573,7 +573,7 @@ class ReactTooltip extends React.Component {`
`573`	`573`	`this.removeListenerForTooltipExit();`
`574`	`574`
`575`	`575`	`this.setState({ show: false }, () => {`
`576`		`- this.removeScrollListener();`
	`576`	`+ this.removeScrollListener(this.state.currentTarget);`
`577`	`577`	`if (isVisible && afterHide) {`
`578`	`578`	`afterHide(e);`
`579`	`579`	`}`
`@@ -604,8 +604,9 @@ class ReactTooltip extends React.Component {`
`604`	`604`	`window.addEventListener("scroll", this.hideTooltipOnScroll, isCaptureMode);`
`605`	`605`	`}`
`606`	`606`
`607`		`- removeScrollListener() {`
`608`		`- window.removeEventListener("scroll", this.hideTooltipOnScroll);`
	`607`	`+ removeScrollListener(currentTarget) {`
	`608`	`+ const isCaptureMode = this.isCapture(currentTarget);`
	`609`	`+ window.removeEventListener("scroll", this.hideTooltipOnScroll, isCaptureMode);`
`609`	`610`	`}`
`610`	`611`
`611`	`612`	`// Calculation the position`