Skip to content

Allow upper case suggestions #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Allow upper case suggestions #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
479254a
Updated onChange
JackTheFlap Feb 26, 2021
a05feae
Update Input.js
JackTheFlap Feb 26, 2021
2e0cbec
Update Input.js
JackTheFlap Feb 26, 2021
2b3a544
Bump to Version 1.03
JackTheFlap Feb 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@reactmaker/react-autocorrect-input",
"description": "Autocorrect input react component, suggested text when you type in.",
"version": "1.0.2",
"version": "1.0.3",
"main": "bin/Input.js",
"repository": {
"type": "git",
Expand Down
21 changes: 6 additions & 15 deletions src/components/Input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,28 +57,19 @@ const initState = {
selectedSuggest: '',
};

export default class ACInput extends React.Component {
export default class ACInput extends React.PureComponent {
inputRef = React.createRef()

state = initState

onChange = (e) => {
const { dataSource, onChange } = this.props;
const { value, selectionStart } = e.target;
// 1. get last keyword
const lastWord = value.split(' ').pop().toLowerCase();
if (!lastWord || selectionStart !== value.length) {
this.setState(initState);
onChange(value);
return;
}
// 2. filter suggest
const { value } = e.target;
// 1. filter suggest
const suggest = dataSource
.map(keyword => keyword.toLowerCase())
.filter(keyword => (keyword.indexOf(lastWord) === 0))
.slice(0, 10);
.filter(keyword => (keyword.toLowerCase().indexOf(value.toLowerCase()) > -1));
const selectedSuggest = suggest[0] || '';
// 3. update suggest array
// 2. update suggest array
this.setState({ suggest, selectedSuggest });
onChange(value);
}
Expand Down Expand Up @@ -160,7 +151,7 @@ export default class ACInput extends React.Component {
style={style}
className={className}
/>
<Style.MenuContainer display={displaySuggest} className={menuClassName}>
<Style.MenuContainer display={displaySuggest.toString()} className={menuClassName}>
{
suggest.map(keyword => (
<Style.MenuLi
Expand Down