Skip to content

Commit e56b527

Browse files
committed
Remove unused vars in initial perlin::noise()
Resolves #684
1 parent bae4802 commit e56b527

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

CHANGELOG.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ Change Log -- Ray Tracing in One Weekend
66
### _In One Weekend_
77
- Fix: replace old anti-alias result image with before-and-after image (#679)
88

9+
### _The Next Week_
10+
- Delete: remove unused u,v,w variables in initial `perlin::noise()` function (#684)
11+
912

1013
----------------------------------------------------------------------------------------------------
1114
# v3.2.0 (2020-07-18)
@@ -220,7 +223,7 @@ adopting, but may warrant comparison with any current projects.
220223

221224
### Common
222225
- Fix: Display rendered images as pixelated instead of smoothed (#179)
223-
- Deleted: delete old README files specific to each book (#410)
226+
- Delete: delete old README files specific to each book (#410)
224227

225228
### _In One Weekend_
226229
- Fix: Remove duplicated text and reword on the camera up vector (#420)
@@ -316,7 +319,7 @@ patch-level (fix) changes and some minor-level (addition) changes.
316319
### _The Rest of Your Life_
317320
- Change: Improved naming of auxilliary programs in _The Rest of Your Life_ source
318321
- Fix: Delete unused variable `p` in main() (#317)
319-
- Deleted: Several unused source files from `src/TheRestOfYourLife`
322+
- Delete: Several unused source files from `src/TheRestOfYourLife`
320323

321324

322325
----------------------------------------------------------------------------------------------------

books/RayTracingTheNextWeek.html

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
[Peter Shirley][]
88
edited by [Steve Hollasch][] and [Trevor David Black][]
99
<br>
10-
Version 3.2.0, 2020-07-18
10+
Version 3.2.1, 2020-XX-XX
1111
<br>
1212
Copyright 2018-2020 Peter Shirley. All rights reserved.
1313

@@ -1443,10 +1443,6 @@
14431443
}
14441444

14451445
double noise(const point3& p) const {
1446-
auto u = p.x() - floor(p.x());
1447-
auto v = p.y() - floor(p.y());
1448-
auto w = p.z() - floor(p.z());
1449-
14501446
auto i = static_cast<int>(4*p.x()) & 255;
14511447
auto j = static_cast<int>(4*p.y()) & 255;
14521448
auto k = static_cast<int>(4*p.z()) & 255;
@@ -1588,10 +1584,10 @@
15881584
public:
15891585
...
15901586
double noise(point3 vec3& p) const {
1587+
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++ highlight
15911588
auto u = p.x() - floor(p.x());
15921589
auto v = p.y() - floor(p.y());
15931590
auto w = p.z() - floor(p.z());
1594-
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++ highlight
15951591

15961592
int i = floor(p.x());
15971593
int j = floor(p.y());
@@ -3356,8 +3352,8 @@
33563352
- **Title (book)**: “Ray Tracing: The Next Week”
33573353
- **Author**: Peter Shirley
33583354
- **Editors**: Steve Hollasch, Trevor David Black
3359-
- **Version/Edition**: v3.2.0
3360-
- **Date**: 2020-07-18
3355+
- **Version/Edition**: v3.2.1
3356+
- **Date**: 2020-XX-XX
33613357
- **URL (series)**: https://raytracing.github.io/
33623358
- **URL (book)**: https://raytracing.github.io/books/RayTracingTheNextWeek.html
33633359

0 commit comments

Comments
 (0)