Merge pull request #394 from Rastaban/perf1

Use references in ranged for loop for performance

Author: hollasch

books/RayTracingInOneWeekend.html

@@ -956,7 +956,7 @@
         bool hit_anything = false;
         auto closest_so_far = t_max;
 
-        for (auto object : objects) {
+        for (const auto& object : objects) {
             if (object->hit(r, t_min, closest_so_far, temp_rec)) {
                 hit_anything = true;
                 closest_so_far = temp_rec.t;

books/RayTracingTheNextWeek.html

@@ -667,7 +667,7 @@
 
         output_box = temp_box;
 
-        for (auto object : objects) {
+        for (const auto& object : objects) {
             if (!objects[i]->bounding_box(t0, t1, temp_box))
                 return false;
             output_box = surrounding_box(output_box, temp_box);

books/RayTracingTheRestOfYourLife.html

@@ -2236,7 +2236,7 @@
         auto weight = 1.0/objects.size();
         auto sum = 0.0;
 
-        for (auto object : objects)
+        for (const auto& object : objects)
             sum += weight * object->pdf_value(o, v);
 
         return sum;

src/InOneWeekend/hittable_list.h

@@ -39,7 +39,7 @@ bool hittable_list::hit(const ray& r, double t_min, double t_max, hit_record& re
     auto hit_anything = false;
     auto closest_so_far = t_max;
 
-    for (auto object : objects) {
+    for (const auto& object : objects) {
         if (object->hit(r, t_min, closest_so_far, temp_rec)) {
             hit_anything = true;
             closest_so_far = temp_rec.t;

src/TheNextWeek/hittable_list.h

@@ -39,7 +39,7 @@ bool hittable_list::hit(const ray& r, double t_min, double t_max, hit_record& re
     auto hit_anything = false;
     auto closest_so_far = t_max;
 
-    for (auto object : objects) {
+    for (const auto& object : objects) {
         if (object->hit(r, t_min, closest_so_far, temp_rec)) {
             hit_anything = true;
             closest_so_far = temp_rec.t;
@@ -62,7 +62,7 @@ bool hittable_list::bounding_box(double t0, double t1, aabb& output_box) const {
 
     output_box = temp_box;
 
-    for (auto object : objects) {
+    for (const auto& object : objects) {
         if (!object->bounding_box(t0, t1, temp_box))
             return false;
         output_box = surrounding_box(output_box, temp_box);

src/TheRestOfYourLife/hittable_list.h

@@ -41,7 +41,7 @@ bool hittable_list::hit(const ray& r, double t_min, double t_max, hit_record& re
     auto hit_anything = false;
     auto closest_so_far = t_max;
 
-    for (auto object : objects) {
+    for (const auto& object : objects) {
         if (object->hit(r, t_min, closest_so_far, temp_rec)) {
             hit_anything = true;
             closest_so_far = temp_rec.t;
@@ -64,7 +64,7 @@ bool hittable_list::bounding_box(double t0, double t1, aabb& output_box) const {
 
     output_box = temp_box;
 
-    for (auto object : objects) {
+    for (const auto& object : objects) {
         if (!object->bounding_box(t0, t1, temp_box))
             return false;
         output_box = surrounding_box(output_box, temp_box);
@@ -78,7 +78,7 @@ double hittable_list::pdf_value(const vec3& o, const vec3& v) const {
     auto weight = 1.0/objects.size();
     auto sum = 0.0;
 
-    for (auto object : objects)
+    for (const auto& object : objects)
         sum += weight * object->pdf_value(o, v);
 
     return sum;