updates after QA

Author: pjbRPF

docs/examples/motion_sensor_callbacks.py

@@ -2,20 +2,17 @@
 from time import sleep
 
 pir = MotionSensor(2)
-led = LED(14)
 
-print("Advanced PIR Motion Sensor Example")
-print("Using event callbacks for motion detection...")
+# Create an LED on pin 25 (built-in LED)
+led = LED(25)
 
 
 def motion_detected():
-    print("🚶 Motion detected!")
-    led.on()  # Turn on LED when motion detected
+    led.on()
 
 
 def no_motion():
-    print("😴 No motion detected")
-    led.off()  # Turn off LED when no motion
+    led.off()
 
 
 # Set up event callbacks

picozero/picozero.py

@@ -1999,6 +1999,35 @@ class Button(Switch):
 Button.when_released = Button.when_deactivated
 
 
+class MotionSensor(DigitalInputDevice):
+    """
+    Represents a PIR (Passive Infrared) motion sensor (e.g. HC-SR501)
+
+    :param int pin:
+        The pin that the motion sensor is connected to.
+
+    :param bool pull_up:
+        If :data:`True` (the default), the device will be pulled up to
+        HIGH. If :data:`False`, the device will be pulled down to LOW.
+        Most PIR sensors work with pull_up=False.
+
+    :param float bounce_time:
+        The bounce time for the device. If set, the device will ignore
+        any motion events that happen within the bounce time after a
+        motion event. This is useful to prevent false triggers.
+        Defaults to 0.02 seconds.
+    """
+
+    def __init__(self, pin, pull_up=False, bounce_time=0.02):
+        super().__init__(pin=pin, pull_up=pull_up, bounce_time=bounce_time)
+
+
+MotionSensor.motion_detected = MotionSensor.is_active
+# Note: No alias for is_inactive - use 'not pir.motion_detected' for clarity
+MotionSensor.when_motion = MotionSensor.when_activated
+MotionSensor.when_no_motion = MotionSensor.when_deactivated
+
+
 class AnalogInputDevice(InputDevice, PinMixin):
     """
     Represents a generic input device with analogue functionality, e.g.
@@ -2247,31 +2276,3 @@ def max_distance(self):
         Returns the maximum distance that the sensor will measure in metres.
         """
         return self._max_distance
-
-
-class MotionSensor(DigitalInputDevice):
-    """
-    Represents a PIR (Passive Infrared) motion sensor (e.g. HC-SR501)
-
-    :param int pin:
-        The pin that the motion sensor is connected to.
-
-    :param bool pull_up:
-        If :data:`True` (the default), the device will be pulled up to
-        HIGH. If :data:`False`, the device will be pulled down to LOW.
-        Most PIR sensors work with pull_up=False.
-
-    :param float bounce_time:
-        The bounce time for the device. If set, the device will ignore
-        any motion events that happen within the bounce time after a
-        motion event. This is useful to prevent false triggers.
-        Defaults to 0.02 seconds.
-    """
-
-    def __init__(self, pin, pull_up=False, bounce_time=0.02):
-        super().__init__(pin=pin, pull_up=pull_up, bounce_time=bounce_time)
-
-
-MotionSensor.motion_detected = MotionSensor.is_active
-MotionSensor.when_motion = MotionSensor.when_activated
-MotionSensor.when_no_motion = MotionSensor.when_deactivated

tests/test_picozero.py

@@ -675,27 +675,5 @@ def test_pico_temp_sensor(self):
         self.assertEqual(pico_temp_sensor.pin, 4)
         self.assertIsNotNone(pico_temp_sensor.temp)
 
-    def test_motion_sensor_aliases(self):
-        """
-        MotionSensor is a simple subclass of DigitalInputDevice that adds
-        aliases. Tests verify the aliases exist and map correctly.
-        """
-        d = MotionSensor(1)
-
-        # Verify that aliases exist and map to the correct properties
-        self.assertTrue(hasattr(d, "motion_detected"))
-        self.assertTrue(hasattr(d, "when_motion"))
-        self.assertTrue(hasattr(d, "when_no_motion"))
-
-        # Verify aliases point to the correct underlying properties
-        self.assertIs(d.motion_detected, d.is_active)
-        self.assertIs(d.when_motion, d.when_activated)
-        self.assertIs(d.when_no_motion, d.when_deactivated)
-
-        # Verify it's properly a DigitalInputDevice subclass
-        self.assertIsInstance(d, DigitalInputDevice)
-
-        d.close()
-
 
 unittest.main()