chore: lint for floating/misused promises (#634)

Fix missing awaits in the tests.

Needed tsconfig information so I've added the project setting - see
https://typescript-eslint.io/blog/parser-options-project-true/#introducing-true

I've done this just for the tests as otherwise we hit issues with the test app
and the webdriver test app not being covered by tsconfig.json files. It could
be trivially extended to the src tree.

Author: microbit-matt-hillsdon

eslint.config.js

@@ -259,4 +259,17 @@ module.exports = [
       '@typescript-eslint/no-require-imports': 'error',
     },
   },
+  {
+    files: ['test/webdriverio/test/*.ts'],
+    languageOptions: {
+      parserOptions: {
+        project: true,
+        tsconfigRootDir: __dirname,
+      },
+    },
+    rules: {
+      '@typescript-eslint/no-floating-promises': 'error',
+      '@typescript-eslint/no-misused-promises': 'error',
+    },
+  },
 ];

test/webdriverio/test/keyboard_mode_test.ts

@@ -86,7 +86,7 @@ suite(
 
       chai.assert.isFalse(await isKeyboardNavigating(this.browser));
 
-      this.browser.execute(() => {
+      await this.browser.execute(() => {
         Blockly.keyboardNavigationController.setIsActive(true);
       });
 
@@ -106,7 +106,7 @@ suite(
 
       chai.assert.isFalse(await isKeyboardNavigating(this.browser));
 
-      this.browser.execute(() => {
+      await this.browser.execute(() => {
         Blockly.keyboardNavigationController.setIsActive(true);
       });
 
@@ -126,7 +126,7 @@ suite(
 
       await this.browser.pause(PAUSE_TIME);
       // Right click a block
-      clickBlock(this.browser, 'controls_if_1', {button: 'right'});
+      await clickBlock(this.browser, 'controls_if_1', {button: 'right'});
       await this.browser.pause(PAUSE_TIME);
 
       chai.assert.isFalse(await isKeyboardNavigating(this.browser));

test/webdriverio/test/scroll_test.ts

@@ -24,7 +24,7 @@ suite('Scrolling into view', function () {
   setup(async function () {
     this.browser = await testSetup(testFileLocations.BASE);
     // Predictable small window size for scrolling.
-    this.browser.setWindowSize(800, 600);
+    await this.browser.setWindowSize(800, 600);
     await this.browser.pause(PAUSE_TIME);
   });
 

test/webdriverio/test/test_setup.ts

@@ -441,10 +441,10 @@ export async function tabNavigateToWorkspace(
   hasFlyout = true,
 ) {
   // Navigate past the initial pre-injection focusable div element.
-  tabNavigateForward(browser);
-  if (hasToolbox) tabNavigateForward(browser);
-  if (hasFlyout) tabNavigateForward(browser);
-  tabNavigateForward(browser); // Tab to the workspace itself.
+  await tabNavigateForward(browser);
+  if (hasToolbox) await tabNavigateForward(browser);
+  if (hasFlyout) await tabNavigateForward(browser);
+  await tabNavigateForward(browser); // Tab to the workspace itself.
 }
 
 /**