refactor(user auth): Improve SignUpView and SignInView implementation

- Refactored SignUpView and SignInView to better leverage DRF generic views and SimpleJWT patterns.
- Simplified view logic by removing manual error handling and post overrides where applicable, relying on serializers and base view implementations.
- Removed redundant imports.
- Removed BaseCustomResponseMixin.

Author: RandomProgramm3r

promo_code/core/views.py

@@ -2,20 +2,9 @@
 import django.views
 import rest_framework.permissions
 import rest_framework.response
-import rest_framework.status
 import rest_framework.views
 
 
-class BaseCustomResponseMixin:
-    error_response = {'status': 'error', 'message': 'Error in request data.'}
-
-    def handle_validation_error(self):
-        return rest_framework.response.Response(
-            self.error_response,
-            status=rest_framework.status.HTTP_400_BAD_REQUEST,
-        )
-
-
 class PingView(django.views.View):
     def get(self, request, *args, **kwargs):
         return django.http.HttpResponse('PROOOOOOOOOOOOOOOOOD', status=200)

promo_code/user/urls.py

@@ -9,12 +9,12 @@
 urlpatterns = [
     django.urls.path(
         'auth/sign-up',
-        user.views.SignUpView.as_view(),
+        user.views.UserSignUpView.as_view(),
         name='sign-up',
     ),
     django.urls.path(
         'auth/sign-in',
-        rest_framework_simplejwt.views.TokenObtainPairView.as_view(),
+        user.views.UserSignInView.as_view(),
         name='sign-in',
     ),
     django.urls.path(

promo_code/user/views.py

@@ -1,67 +1,39 @@
-import rest_framework.exceptions
 import rest_framework.generics
 import rest_framework.response
-import rest_framework.serializers
 import rest_framework.status
-import rest_framework_simplejwt.exceptions
 import rest_framework_simplejwt.tokens
 import rest_framework_simplejwt.views
 
-import core.views
 import user.serializers
 
 
-class SignUpView(
-    core.views.BaseCustomResponseMixin,
+class UserSignUpView(
     rest_framework.generics.CreateAPIView,
 ):
     serializer_class = user.serializers.SignUpSerializer
 
     def create(self, request, *args, **kwargs):
         serializer = self.get_serializer(data=request.data)
-
-        try:
-            serializer.is_valid(raise_exception=True)
-        except rest_framework.exceptions.ValidationError:
-            return self.handle_validation_error()
+        serializer.is_valid(raise_exception=True)
 
         user = serializer.save()
-
         refresh = rest_framework_simplejwt.tokens.RefreshToken.for_user(user)
         refresh['token_version'] = user.token_version
+
         access_token = refresh.access_token
 
+        response_data = {
+            'access': str(access_token),
+            'refresh': str(refresh),
+        }
+
         return rest_framework.response.Response(
-            {'access': str(access_token), 'refresh': str(refresh)},
+            response_data,
             status=rest_framework.status.HTTP_200_OK,
         )
 
 
-class SignInView(
-    core.views.BaseCustomResponseMixin,
+class UserSignInView(
     rest_framework_simplejwt.views.TokenObtainPairView,
 ):
     serializer_class = user.serializers.SignInSerializer
-
-    def post(self, request, *args, **kwargs):
-        try:
-            serializer = self.get_serializer(data=request.data)
-            serializer.is_valid(raise_exception=True)
-        except (
-            rest_framework.serializers.ValidationError,
-            rest_framework_simplejwt.exceptions.TokenError,
-        ) as e:
-            if isinstance(e, rest_framework.serializers.ValidationError):
-                return self.handle_validation_error()
-
-            raise rest_framework_simplejwt.exceptions.InvalidToken(str(e))
-
-        response_data = {
-            'access': serializer.validated_data['access'],
-            'refresh': serializer.validated_data['refresh'],
-        }
-
-        return rest_framework.response.Response(
-            response_data,
-            status=rest_framework.status.HTTP_200_OK,
-        )