"href" can now contain an empty value

RandomHashTags · RandomHashTags · commit 0979f7663d91 · 2024-10-23T07:50:57.000-05:00
- which is valid html, but was optimized out by this library
diff --git a/Sources/HTMLKitMacros/HTMLElement.swift b/Sources/HTMLKitMacros/HTMLElement.swift
@@ -209,7 +209,7 @@ private extension HTMLElement {
             switch returnType {
             case .boolean: return string.elementsEqual("true") ? "" : nil
             case .string, .enumCase:
-                if returnType == .string && string.isEmpty {
+                if returnType == .string && string.isEmpty && key != "href" {
                     return nil
                 }
                 string.escapeHTML(escapeAttributes: true)
diff --git a/Tests/HTMLKitTests/HTMLKitTests.swift b/Tests/HTMLKitTests/HTMLKitTests.swift
@@ -95,6 +95,20 @@ extension HTMLKitTests {
         string = #html(xmlns: "test")
         #expect(string == "<!DOCTYPE html><html xmlns=\"test\"></html>")
     }
+    @Test func element_a() {
+        var string:String = #a("Test")
+        #expect(string == "<a>Test</a>")
+
+        string = #a(href: "test", "Test")
+        #expect(string == "<a href=\"test\">Test</a>")
+
+        string = #a(href: "", "Test")
+        #expect(string == "<a href>Test</a>")
+
+        let test:String = "test"
+        string = #a(href: "\(test)", "Test")
+        #expect(string == "<a href=\"test\">Test</a>")
+    }
     @Test func element_area() {
         var string:StaticString = #area(coords: [1, 2, 3])
         #expect(string == "<area coords=\"1,2,3\">")

Original file line number	Diff line number	Diff line change
`@@ -209,7 +209,7 @@ private extension HTMLElement {`
`209`	`209`	`switch returnType {`
`210`	`210`	`case .boolean: return string.elementsEqual("true") ? "" : nil`
`211`	`211`	`case .string, .enumCase:`
`212`		`- if returnType == .string && string.isEmpty {`
	`212`	`+ if returnType == .string && string.isEmpty && key != "href" {`
`213`	`213`	`return nil`
`214`	`214`	`}`
`215`	`215`	`string.escapeHTML(escapeAttributes: true)`