Skip to content

Commit 273185b

Browse files
authored
doxygen: fix two issues when building with doxygen 1.9.8 (#10768)
* doxygen: remove @return command if function return void When doxygen is upgraded to v1.9.8 (on ubuntu 24.04), doxygen reports: "doxygen error: found documented return type for xxx that does not return anything" for those functions which return void but declare "@return" in doxygen comment. Solution: remove "@return" for those cases, and update guide document for how to write doxgen comment for functions. Signed-off-by: Chen Wang <unicorn_wang@outlook.com> * doxygen: fixed a minor typo for uart doc This error is found when building with doxygen 1.9.8, but not detecetd on 1.9.1. Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
1 parent 1aef0db commit 273185b

File tree

4 files changed

+7
-13
lines changed

4 files changed

+7
-13
lines changed

components/drivers/audio/dev_audio.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -751,8 +751,6 @@ int rt_audio_samplerate_to_speed(rt_uint32_t bitValue)
751751
* See _audio_send_replay_frame for details
752752
*
753753
* @param[in] audio pointer to audio device
754-
*
755-
* @return void
756754
*/
757755
void rt_audio_tx_complete(struct rt_audio_device *audio)
758756
{
@@ -768,8 +766,6 @@ void rt_audio_tx_complete(struct rt_audio_device *audio)
768766
* @param[in] pbuf pointer ro data to be received
769767
*
770768
* @param[in] len buffer size
771-
*
772-
* @return void
773769
*/
774770
void rt_audio_rx_done(struct rt_audio_device *audio, rt_uint8_t *pbuf, rt_size_t len)
775771
{

components/drivers/include/drivers/dev_can.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -709,8 +709,6 @@ rt_err_t rt_hw_can_register(struct rt_can_device *can,
709709
*
710710
* @param[in] can A pointer to the CAN device structure.
711711
* @param[in] event The interrupt event mask, indicating the cause of the interrupt.
712-
*
713-
* @return void
714712
*/
715713
void rt_hw_can_isr(struct rt_can_device *can, int event);
716714

documentation/0.doxygen/example/src/function.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,12 @@
3333
*
3434
* To documenting for functions, a comment block before the function
3535
* declaraion/definition is recommended to describe the general information
36-
* of the function. In the comment block, a `@brief` is required, a `@return`
37-
* is also required no matter if the function return values or not. `@param` is
38-
* required if any, and if it is provided, direction [in]/[out]/[in,out] should
39-
* be provide together. Other commands (such as `@note`) are optional.
36+
* of the function. In the comment block, a `@brief` is required. A `@return`
37+
* is also required if the function is intended to return a value, otherwise
38+
* if the function is implemented with a void return type, `@return` is not
39+
* required. `@param` is required if any, and if it is provided,
40+
* direction [in]/[out]/[in,out] should be provide together. Other commands
41+
* (such as `@note`) are optional.
4042
*
4143
* If you feel that the description of `@brief` is not enough, you
4244
* can add a detailed description part, which is also optional.
@@ -72,8 +74,6 @@
7274
*
7375
* @param[in] b Description of param b
7476
*
75-
* @return void
76-
*
7777
* @note This is a note for this structure, blah blah blah...
7878
*/
7979
void doxygen_example_func_foo(int a, int b)

documentation/6.components/device-driver/uart/uart.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ There are three modes of uart data receiving and sending: interrupt mode, pollin
8686

8787
The DMA (Direct Memory Access) transfer mode does not require the CPU to directly control the transfer, and does not have the process of reserving the scene and restoring the scene as they have in the interrupt processing mode. The DMA controller opens a path for directly transferring data to the RAM and the I/O device, which saves CPU resources to do other things. Using DMA transfer can continuously acquire or send a piece of information without taking up interrupts or delays, which is useful when communication is frequent or when large pieces of information are to be transmitted.
8888

89-
>RT_DEVICE_FLAG_STREAM: Stream mode is used to output a string to the serial terminal: when the output character is `"\n"` (corresponding to the hexadecimal value 0x0A), a ``\r"` is automatically output in front (corresponding to hexadecimal value is 0x0D).
89+
> RT_DEVICE_FLAG_STREAM: Stream mode is used to output a string to the serial terminal: when the output character is `"\n"` (corresponding to the hexadecimal value 0x0A), a `"\r"` is automatically output in front (corresponding to hexadecimal value is 0x0D).
9090
9191
The stream mode `RT_DEVICE_FLAG_STREAM` can be used with the receive and send mode parameter with the "|" logic.
9292

0 commit comments

Comments
 (0)