From 18287afc96eb1542224ee4fa431d9f1a04056107 Mon Sep 17 00:00:00 2001
From: kwangwon <kwangwon.park@moreh.io>
Date: Tue, 22 Apr 2025 12:10:31 +0900
Subject: [PATCH 1/2] Set args, command for helm chart

---
 helm/amd-gpu/templates/deviceplugin-daemonset.yaml | 4 ++++
 helm/amd-gpu/values.yaml                           | 2 ++
 2 files changed, 6 insertions(+)

diff --git a/helm/amd-gpu/templates/deviceplugin-daemonset.yaml b/helm/amd-gpu/templates/deviceplugin-daemonset.yaml
index 6196d55ed..4609004ce 100644
--- a/helm/amd-gpu/templates/deviceplugin-daemonset.yaml
+++ b/helm/amd-gpu/templates/deviceplugin-daemonset.yaml
@@ -45,6 +45,10 @@ spec:
               mountPath: /var/lib/amd-metrics-exporter/
           resources:
             {{- toYaml .Values.dp.resources | nindent 12 }}
+          args:
+            {{- toYaml .Values.dp.args | nindent 12 }}
+          command:
+            {{- toYaml .Values.dp.command | nindent 12 }}
       volumes:
         - name: dp
           hostPath:
diff --git a/helm/amd-gpu/values.yaml b/helm/amd-gpu/values.yaml
index 04c49cdb4..2ad793296 100644
--- a/helm/amd-gpu/values.yaml
+++ b/helm/amd-gpu/values.yaml
@@ -15,6 +15,8 @@ dp:
     type: RollingUpdate
     rollingUpdate:
       maxUnavailable: 1
+  args: []
+  command: []
 
 lbl:
   image:

From 1c7fcbdd74e65efdc7d6e259ee80bd02411a0af9 Mon Sep 17 00:00:00 2001
From: kwang1121 <kwg0109@gmail.com>
Date: Wed, 23 Apr 2025 10:26:48 +0900
Subject: [PATCH 2/2] apply PR comment. add default values

---
 helm/amd-gpu/templates/deviceplugin-daemonset.yaml | 8 ++++----
 helm/amd-gpu/values.yaml                           | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/helm/amd-gpu/templates/deviceplugin-daemonset.yaml b/helm/amd-gpu/templates/deviceplugin-daemonset.yaml
index 4609004ce..4332ac6d5 100644
--- a/helm/amd-gpu/templates/deviceplugin-daemonset.yaml
+++ b/helm/amd-gpu/templates/deviceplugin-daemonset.yaml
@@ -34,6 +34,10 @@ spec:
       containers:
         - name: {{ .Chart.Name }}-dp-cntr
           image: {{ .Values.dp.image.repository }}:{{ .Values.dp.image.tag | default .Chart.AppVersion }}
+          command:
+            {{- toYaml .Values.dp.command | nindent 12 }}
+          args:
+            {{- toYaml .Values.dp.args | nindent 12 }}
           securityContext:
             {{- toYaml .Values.securityContext | nindent 12 }}
           volumeMounts:
@@ -45,10 +49,6 @@ spec:
               mountPath: /var/lib/amd-metrics-exporter/
           resources:
             {{- toYaml .Values.dp.resources | nindent 12 }}
-          args:
-            {{- toYaml .Values.dp.args | nindent 12 }}
-          command:
-            {{- toYaml .Values.dp.command | nindent 12 }}
       volumes:
         - name: dp
           hostPath:
diff --git a/helm/amd-gpu/values.yaml b/helm/amd-gpu/values.yaml
index 2ad793296..f980afb86 100644
--- a/helm/amd-gpu/values.yaml
+++ b/helm/amd-gpu/values.yaml
@@ -9,14 +9,14 @@ dp:
     repository: docker.io/rocm/k8s-device-plugin
     # Overrides the image tag whose default is the chart appVersion.
     tag: "1.31.0.6"
+  command: ["./k8s-device-plugin"]
+  args: ["-logtostderr=true", "-stderrthreshold=INFO", "-v=5"] 
   resources: {}
   # Set daemonsets updateStrategy for device plugin
   updateStrategy:
     type: RollingUpdate
     rollingUpdate:
       maxUnavailable: 1
-  args: []
-  command: []
 
 lbl:
   image: